Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: disable image upload support in description editor #17697

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Sep 4, 2024

Before

Screen.Recording.2024-09-04.at.1.54.10.PM.mov

After

Screen.Recording.2024-09-04.at.2.37.18.PM.mov

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.12% (37175/57087) 41.58% (14776/35537) 43.93% (4524/10299)

chirag-madlani
chirag-madlani previously approved these changes Sep 4, 2024
pmbrull
pmbrull previously approved these changes Sep 4, 2024
Copy link

sonarcloud bot commented Sep 5, 2024

@chirag-madlani chirag-madlani merged commit e337a57 into main Sep 5, 2024
17 of 18 checks passed
@chirag-madlani chirag-madlani deleted the minor-remove-image-blob-support branch September 5, 2024 07:40
Sachin-chaurasiya added a commit that referenced this pull request Sep 5, 2024
* minor: disable image upload support in description editor

* feat: Disable image upload support in description editor

* address comment

* fix : unit test

---------

Co-authored-by: Chirag Madlani <[email protected]>
(cherry picked from commit e337a57)
hurongliang added a commit to hurongliang/OpenMetadata that referenced this pull request Sep 6, 2024
* main: (39 commits)
  MINOR - Better PII classification for JSON data (open-metadata#17734)
  New Email Templates (OSS) (open-metadata#17606)
  fix pom. (open-metadata#17682)
  GEN-1333 Add TS validation on DQ and Porfiler data ingestion (open-metadata#17731)
  make cost analysis as collate only (open-metadata#17719)
  Minor: remove unused dependency (open-metadata#17709)
  test: migrate login config to playwright (open-metadata#17740)
  minor(test): fix ingestion related flaky for aut (open-metadata#17727)
  fix expand all operation on terms page (open-metadata#17733)
  Docs: Updating the Image Reference for Bots (open-metadata#17736)
  fix ui freezing due to images in feed changes (open-metadata#17703)
  add links to menus (open-metadata#17659)
  supported followed data in Following widget using search api (open-metadata#17689)
  minor(ui): align dependency version to fix vulnerabilities (open-metadata#17729)
  Fixes some things on the APICollection (open-metadata#17704)
  DOCS - OSS deployment is flagged as Collate False (open-metadata#17722)
  minor: disable image upload support in description editor (open-metadata#17697)
  fix user spec flaky playwright test (open-metadata#17684)
  fetch domains before any widget is loaded (open-metadata#17695)
  minor(test): migrate persona spec (open-metadata#17701)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants