fetch domains before any widget is loaded #17695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanh37
requested review from
ShaileshParmar11,
chirag-madlani and
Sachin-chaurasiya
as code owners
github-actions
bot
added
the
safe to test
karanh37
added
e2e
openmetadata
|
||||||||||||||||||||||||||||
| Project |
openmetadata
|
| Branch Review |
domain-ordering-fixes
|
| Run status |
|
| Run duration | 14m 40s |
| Commit |
|
| Committer | Karan Hotchandani |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
12
|
Skipped
|
0
|
Passing
|
140
|
| View all changes introduced in this branch ↗︎ | |
chirag-madlani
previously approved these changes
Sep 4, 2024
Sachin-chaurasiya
previously approved these changes
Sep 4, 2024
karanh37
dismissed stale reviews from Sachin-chaurasiya and chirag-madlani
via
416f65d
| @@ -182,7 +182,7 @@ export const fillRule = async ( | |||
| } | |||
|
|
|||
| await page | |||
| .locator(`.ant-select-dropdown [title="${searchData}"]`) | |||
| .locator(`.ant-select-dropdown:visible [title="${searchData}"]`) | |||
There was a problem hiding this comment.
Consider above approach to point to latest dropdown options
chirag-madlani
approved these changes
Sep 4, 2024
|
chirag-madlani
approved these changes
Sep 5, 2024
karanh37
added a commit
that referenced
this pull request
Sep 5, 2024
* fix domain init ordering * move domains call at the beginning * fix tests * fix tests * fix flaky tests * fix flaky tests (cherry picked from commit 1dc15bc)
hurongliang
added a commit
to hurongliang/OpenMetadata
that referenced
this pull request
Sep 6, 2024
* main: (39 commits) MINOR - Better PII classification for JSON data (open-metadata#17734) New Email Templates (OSS) (open-metadata#17606) fix pom. (open-metadata#17682) GEN-1333 Add TS validation on DQ and Porfiler data ingestion (open-metadata#17731) make cost analysis as collate only (open-metadata#17719) Minor: remove unused dependency (open-metadata#17709) test: migrate login config to playwright (open-metadata#17740) minor(test): fix ingestion related flaky for aut (open-metadata#17727) fix expand all operation on terms page (open-metadata#17733) Docs: Updating the Image Reference for Bots (open-metadata#17736) fix ui freezing due to images in feed changes (open-metadata#17703) add links to menus (open-metadata#17659) supported followed data in Following widget using search api (open-metadata#17689) minor(ui): align dependency version to fix vulnerabilities (open-metadata#17729) Fixes some things on the APICollection (open-metadata#17704) DOCS - OSS deployment is flagged as Collate False (open-metadata#17722) minor: disable image upload support in description editor (open-metadata#17697) fix user spec flaky playwright test (open-metadata#17684) fetch domains before any widget is loaded (open-metadata#17695) minor(test): migrate persona spec (open-metadata#17701) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>