Get a .NET Core project to build in AppVeyor and Travis #1462

mderriey · 2016-09-09T11:25:03Z

First step of #1419.

It looks like AppVeyor has the dotnet CLI installed in the image so no need to download it.
Also, that's really as simple as it gets. Maybe you wanted something more ... realistic.

Made some comments in the F# code where I'm really not sure if that's The Way To Do Things.

mderriey · 2016-09-09T11:38:08Z

build.fsx

+          WorkingDir = "./Octokit.Next" })
+
+    !! "./Octokit.Next/project.json"
+    |> Fake.DotNetCli.Build (fun p -> p)


maybe there's an easier way than (fun p -> p) to return the input parameter as is

mderriey · 2016-09-10T12:12:17Z

I'm struggling a bit to gauge how simple the .NET Core has to be.

Is the intent realy only to have a .NET Core, no matter how small it is, to build on AppVeyor? Or do we want to try tackling the porting to the existing projects to .NET Core?

Thanks!
/cc @shiftkey

shiftkey · 2016-09-11T23:26:12Z

@mderriey the reason why I suggest getting a trivial .NET Core thing building is that I fear there's lots of integration hassles waiting for us getting this running on both Travis and Appveyor.

based on https://github.com/enricosada/fsharp-dotnet-cli-samples/blob/rel/1.0.0-preview2/.travis.yml

mderriey · 2016-09-12T11:29:58Z

For the sake of simplicity, I went with a separate VS solution containing a very simple class library and a unit tests project.

It took a few trial and error tries to get it working on Travis CI.

mderriey · 2016-09-14T03:45:33Z

Is that a good enough baseline to start with the port? How should we proceed?

shiftkey · 2016-09-14T03:49:33Z

.travis.yml

+      dotnet: 1.0.0-preview2-003121
+
+script:
+  - dotnet --info


Can we put the existing build steps in here, so they both run?

shiftkey · 2016-09-14T03:52:43Z

@mderriey I like where this is heading. If it's too hard to run both the original build and this new build (for example, if we hit timeouts with CI), then let's verify we can test the .NET Core project from the command line at least

mderriey · 2016-09-14T07:35:39Z

Sure, I'll bring the existing build targets back.

If it's too hard to run both the original build and this new build (for example, if we hit timeouts with CI), then let's verify we can test the .NET Core project from the command line at least

I didn't get this part, sorry. The new build does execute tests, but I'm sure you saw that, so I must miss something.

Also, a couple of random questions:

for the time being, are we happy to duplicate source files in the new projects? Having both .csproj and project.json seems to be causing issues with MSBuild wanting more target frameworks in the project.json
if it turns out netstandard1.1 is all we need, are we happy to have it as the only target?

shiftkey · 2016-09-14T11:36:53Z

The new build does execute tests, but I'm sure you saw that, so I must miss something.

Yes, I wasn't clear. Am I able to run the same command locally? Or are there other dependencies I need.

for the time being, are we happy to duplicate source files in the new projects? Having both .csproj and project.json seems to be causing issues with MSBuild wanting more target frameworks in the project.json

I'd rather not do this, and the MSBuild issues are similar to what I was seeing a while ago.

if it turns out netstandard1.1 is all we need, are we happy to have it as the only target?

I'm fine with targeting this initially as a new platform, as adding in extra platforms is rather straightforward. My main focus initially is ensuring we support the current platforms in project.json as well...

mderriey · 2016-09-14T12:04:47Z

Yes, I wasn't clear. Am I able to run the same command locally? Or are there other dependencies I need.

As long as you have the dotnet CLI, then yeah, you can execute the build target to run .NET Core tests.

I'd rather not do this, and the MSBuild issues are similar to what I was seeing a while ago.

Understood. Will investigate on this a bit more by having a look at the branch you mentioned before.

I'm fine with targeting this initially as a new platform, as adding in extra platforms is rather straightforward. My main focus initially is ensuring we support the current platforms in project.json as well...

That's consistent with what you said just before.

Finally, the build timed out on Travis with both the existing and the new build. Can we kick off a new one without pushing changes to that branch just in case?

shiftkey · 2016-09-14T22:18:04Z

As long as you have the dotnet CLI, then yeah, you can execute the build target to run .NET Core tests.

Do you think it's worth installing the dotnet CLI locally, like we do for Rx.NET?

mderriey · 2016-09-14T22:33:09Z

Hmm.

I'd say no. Let's say you're willing to work on the port to .NET Core, you'll need to install .NET Core runtime and tooling anyway. Another argument for not installing it as part of the build is that both AppVeyor and Travis support it, which saves us from installing it ourselves on the build agents.

Does that answer your question?

shiftkey · 2016-09-14T22:33:45Z

@mderriey all good points 👍

mderriey · 2016-09-14T22:39:22Z

Cool.

I've just noticed another build started on Travis for this commit - use mono 4.2.3 as latest successful builds show this version was used.

Did you start this explicitly or does Travis have a retry mechanism when a build times out?

shiftkey · 2016-09-14T22:42:02Z

@mderriey nope, this is me restarting the build

trying to get the build not to hang on Mac OS

The default Mac OS image is not compatible with .NET Core see https://travis-ci.org/octokit/octokit.net/jobs/160036868

shiftkey · 2016-09-15T02:52:51Z

This seems to be an upstream problem 😞

Unhandled Exception: System.TypeInitializationException: The type initializer for 'Crypto' threw an exception. ---> System.TypeInitializationException: The type initializer for 'CryptoInitializer' threw an exception. ---> System.DllNotFoundException: Unable to load DLL 'System.Security.Cryptography.Native': The specified module could not be found.

Disclaimer: I have no idea what I'm doing. See dotnet/core#173

I don't know much more about it than the previous commit

mderriey · 2016-09-15T08:55:22Z

Well that's weird, the last build passed but this one didn't, the only change being to bring back linux again and adding a condition around if the OS is OSX to link libs.

@shiftkey could you please restart the build for that last commit when you have some time? And just in case, could you check the last commit see if I did something wrong? My bash-fu is not very good.

mderriey · 2016-09-15T10:47:20Z

Great, thanks! 👍
Let's just hope the build won't be too flakey.

I'll start working on moving existing platforms to project.json. If I understand this right, and if all the current platforms are supported by project.json, we could end up with only one Octokit project in the solution.

Some posts I want to keep as a reference here:

Thanks again!

shiftkey · 2016-09-15T11:30:43Z

@mderriey that's fine, we can keep an eye on it over time.

Thanks for getting started on this!

mderriey · 2016-09-15T12:08:53Z

@shiftkey Thanks!

I could have squashed all these commits, it's a bit embarrassing to be honest.

shiftkey · 2016-09-15T23:26:16Z

I could have squashed all these commits, it's a bit embarrassing to be honest.

Eh, it's fine. Onward and upward.

mderriey reviewed Sep 9, 2016
View reviewed changes

mderriey added 4 commits September 12, 2016 20:06

adding .NET Core solution and projects

cbc102a

update FAKE to get dotnet CLI support

091f9bd

add .NET Core targets in FAKE build script

3eb2729

first try at modifying the AppVeyor and Travis files

341acd2

mderriey changed the title ~~[WIP] - Get a .NET Core project to build in AppVeyor~~ [WIP] - Get a .NET Core project to build in AppVeyor and Travis Sep 12, 2016

mderriey added 2 commits September 12, 2016 21:14

try something else for Travis

85f8a4c

based on https://github.com/enricosada/fsharp-dotnet-cli-samples/blob/rel/1.0.0-preview2/.travis.yml

add mono. of course we need it to install NuGet dependencies

297fe2f

shiftkey reviewed Sep 14, 2016
View reviewed changes

.travis.yml

dotnet: 1.0.0-preview2-003121

script:

- dotnet --info

Copy link

Member

shiftkey Sep 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put the existing build steps in here, so they both run?

mderriey added 2 commits September 14, 2016 19:28

bring back original build tasks

eb57ebd

use mono 4.2.3 as latest successful builds show this version was used

b3c1c80

shiftkey self-assigned this Sep 14, 2016

mderriey added 2 commits September 15, 2016 09:44

remove specific osx_image

9c95477

trying to get the build not to hang on Mac OS

add other specific osx_image

893c184

The default Mac OS image is not compatible with .NET Core see https://travis-ci.org/octokit/octokit.net/jobs/160036868

mderriey added 4 commits September 15, 2016 13:54

try to work around Homebrew refusing to link OpenSSL

7678ba8

Disclaimer: I have no idea what I'm doing. See dotnet/core#173

and again I try

26b15dd

I don't know much more about it than the previous commit

yet another try - probably not the last

2de3c73

brincg back linux since last build passed

766d3e2

shiftkey changed the title ~~[WIP] - Get a .NET Core project to build in AppVeyor and Travis~~ Get a .NET Core project to build in AppVeyor and Travis Sep 15, 2016

shiftkey merged commit c9b2c12 into octokit:master Sep 15, 2016

ryangribble mentioned this pull request Sep 29, 2016

support for .NET Core and Portable PDB files ctaggart/SourceLink#121

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get a .NET Core project to build in AppVeyor and Travis #1462

Get a .NET Core project to build in AppVeyor and Travis #1462

mderriey commented Sep 9, 2016 •

edited

Loading

mderriey Sep 9, 2016

mderriey commented Sep 10, 2016

shiftkey commented Sep 11, 2016

mderriey commented Sep 12, 2016

mderriey commented Sep 14, 2016

shiftkey Sep 14, 2016

shiftkey commented Sep 14, 2016 •

edited

Loading

mderriey commented Sep 14, 2016

shiftkey commented Sep 14, 2016

mderriey commented Sep 14, 2016

shiftkey commented Sep 14, 2016

mderriey commented Sep 14, 2016

shiftkey commented Sep 14, 2016

mderriey commented Sep 14, 2016 •

edited

Loading

shiftkey commented Sep 14, 2016

shiftkey commented Sep 15, 2016 •

edited

Loading

mderriey commented Sep 15, 2016

mderriey commented Sep 15, 2016

shiftkey commented Sep 15, 2016

mderriey commented Sep 15, 2016

shiftkey commented Sep 15, 2016

Get a .NET Core project to build in AppVeyor and Travis #1462

Get a .NET Core project to build in AppVeyor and Travis #1462

Conversation

mderriey commented Sep 9, 2016 • edited Loading

mderriey Sep 9, 2016

Choose a reason for hiding this comment

mderriey commented Sep 10, 2016

shiftkey commented Sep 11, 2016

mderriey commented Sep 12, 2016

mderriey commented Sep 14, 2016

shiftkey Sep 14, 2016

Choose a reason for hiding this comment

shiftkey commented Sep 14, 2016 • edited Loading

mderriey commented Sep 14, 2016

shiftkey commented Sep 14, 2016

mderriey commented Sep 14, 2016

shiftkey commented Sep 14, 2016

mderriey commented Sep 14, 2016

shiftkey commented Sep 14, 2016

mderriey commented Sep 14, 2016 • edited Loading

shiftkey commented Sep 14, 2016

shiftkey commented Sep 15, 2016 • edited Loading

mderriey commented Sep 15, 2016

mderriey commented Sep 15, 2016

shiftkey commented Sep 15, 2016

mderriey commented Sep 15, 2016

shiftkey commented Sep 15, 2016

mderriey commented Sep 9, 2016 •

edited

Loading

shiftkey commented Sep 14, 2016 •

edited

Loading

mderriey commented Sep 14, 2016 •

edited

Loading

shiftkey commented Sep 15, 2016 •

edited

Loading