support for .NET Core and Portable PDB files

[cloudRoutine]

Any chance of this happening?

[ctaggart]

There is a good chance. I'm waiting for upstream support to happen:
- [x] Paket fsprojects/Paket#1785
- [x] Argu fsprojects/Argu#57
- [ ] FAKE fsprojects/FAKE#1281
- [x] MSBuild https://github.com/microsoft/msbuild/ issue?

[ctaggart]

https://github.com/dotnet/symstore

[ryangribble]

We are working on moving octokit.net to .NET core and as you know, we use SourceLink currently.

The mentioned upstream dependencies are good now I think... 2 of the linked issues are merged and although the FAKE one isnt merged, I do know we were building a sample app with a recent FAKE version (4.39.1)

So any hopes of SourceLink support for project.json/xproj dotnetcore projects? 😀

[ctaggart]

Hi @ryangribble, I'm going to wait until the next release where they adopt MSBuild again. It should be soon, I hope.

We’ve talked about future updates to .NET Core, including adopting MSBuild and establishing .NET Standard 2.0. These changes will be included in an upcoming feature release and not in a patch version like the one we are releasing today.

[ctaggart]

I got introduced to the updated dotnet cli tooling that uses the revamped msbuild and it is a great improvement! I was up in Redmond this last week for the MS MVP conference. I need to figure out how to add a dotnet sourcelink that would happen just before a dotnet build when doing a dotnet pack or something like that. There is some updated tooling for portable pdb files being shipped with .NET Core 1.1 I think. I put in a plea to the NuGet team to bless packaging portable pdb files and it sounds like it may happen.

[ctaggart]

With the Visual Studio 2017 RC out and with the updated msbuild support, it looks like a good time to create the MSBuild task for SourceLink as specified here:
dotnet/roslyn#12759

[ctaggart]

Visual Studio 2017 RC3 has Enable source link support as an option in Debugging that is on by default!

I am just getting caught up on this week's updates in dotnet/roslyn#12759.

[ctaggart]

It indeed works for portable pdb files with Visual Studio 2017 RC3! I just got prompted with:

It just did a regular http get without any additional headers:

csproj had file handcrafted:

<SourceLink>C:\Users\camer\cs\sourcelink-test\src\ClassLibrary1\SourceLink.json</SourceLink>

SourceLink.json was

{"documents": { "C:\\Users\\camer\\cs\\sourcelink-test\\src\\ClassLibrary1\\Class1.cs" : "https://raw.githubusercontent.com/stffabi/sourcelink-test/b5012a98bed12f6704cb942e92ba34ccdbd920d8/src/ClassLibrary1/Class1.cs" }}

[ctaggart]

@cloudRoutine @ryangribble @tmat @AArnott
SourceLink v2 is feature complete just now. I uploaded the latest builds to NuGet Gallery. Can you have a look at instructions about v2 here:

https://github.com/ctaggart/SourceLink

There is also an example of putting the references in a separate file here:
https://github.com/ctaggart/sourcelink-test/tree/master/src/ClassLibrary1