Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin dependency versions in rust model #2048

Merged
merged 4 commits into from
Sep 9, 2024
Merged

chore: pin dependency versions in rust model #2048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e5f0ec
chore: pin kube version in rust
whynowy Sep 9, 2024
5ece879
.
whynowy Sep 9, 2024
86804f3
.
whynowy Sep 9, 2024
e188901
move to template
whynowy Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions rust/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/monovertex/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pep440_rs = "0.6.6"
backoff = { path = "../backoff" }
parking_lot = "0.12.3"
prometheus-client = "0.22.3"
kube = "0.93.1"
kube = "0.94.0"

[dev-dependencies]
tempfile = "3.11.0"
Expand Down
2 changes: 1 addition & 1 deletion rust/numaflow-models/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ edition = "2021"

[dependencies]
k8s-openapi = { version = "0.22.0", features = ["v1_29"] }
kube = "0.93.1"
kube = "0.94.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason? we have marked k8s-openapi to include only v1_29 feature. we might have to pin k8s-openapi too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid unexpected new release caused build problem

serde = "^1.0"
serde_derive = "^1.0"
serde_json = "^1.0"
Expand Down
2 changes: 0 additions & 2 deletions rust/numaflow-models/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,4 @@ generate:
--type-mappings IntOrString="k8s_openapi::apimachinery::pkg::util::intstr::IntOrString" \
--generate-alias-as-model

cargo add kube
cargo add k8s-openapi --features v1_29
cargo fmt
53 changes: 4 additions & 49 deletions rust/numaflow-models/templates/Cargo.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,65 +1,20 @@
[package]
name = "{{{packageName}}}"
version = "{{#lambdaVersion}}{{{packageVersion}}}{{/lambdaVersion}}"
{{#infoEmail}}
authors = ["{{{.}}}"]
{{/infoEmail}}
{{^infoEmail}}
name = "numaflow-models"
version = "0.0.0-pre"
authors = ["The Numaproj Authors"]
{{/infoEmail}}
{{#appDescription}}
description = "Numaflow models"
{{/appDescription}}
license = "Apache-2.0 license"
edition = "2021"
{{#publishRustRegistry}}
publish = ["{{.}}"]
{{/publishRustRegistry}}
{{#repositoryUrl}}
repository = "{{.}}"
{{/repositoryUrl}}
{{#documentationUrl}}
documentation = "{{.}}"
{{/documentationUrl}}
{{#homePageUrl}}
homepage = "{{.}}
{{/homePageUrl}}

[dependencies]
k8s-openapi = { version = "0.22.0", features = ["v1_29"] }
kube = "0.94.0"
serde = "^1.0"
serde_derive = "^1.0"
{{#serdeWith}}
serde_with = "^2.0"
{{/serdeWith}}
serde_json = "^1.0"
url = "^2.2"
uuid = { version = "^1.0", features = ["serde", "v4"] }
{{#hyper}}
hyper = { version = "~0.14", features = ["full"] }
hyper-tls = "~0.5"
http = "~0.2"
base64 = "~0.7.0"
futures = "^0.3"
{{/hyper}}
{{#withAWSV4Signature}}
aws-sigv4 = "0.3.0"
http = "0.2.5"
secrecy = "0.8.0"
{{/withAWSV4Signature}}
{{#reqwest}}
{{^supportAsync}}
[dependencies.reqwest]
version = "^0.11"
default-features = false
features = ["json", "blocking", "multipart", "rustls-tls"]
{{/supportAsync}}
{{#supportAsync}}
{{#supportMiddleware}}
reqwest-middleware = "0.2.0"
{{/supportMiddleware}}
[dependencies.reqwest]
version = "^0.11"
default-features = false
features = ["json", "multipart", "rustls-tls"]
{{/supportAsync}}
{{/reqwest}}
Loading