chore: pin dependency versions in rust model #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
vigith
reviewed
Sep 9, 2024
| @@ -8,7 +8,7 @@ edition = "2021" | |||
|
|
|||
| [dependencies] | |||
| k8s-openapi = { version = "0.22.0", features = ["v1_29"] } | |||
| kube = "0.93.1" | |||
| kube = "0.94.0" | |||
There was a problem hiding this comment.
any particular reason? we have marked k8s-openapi to include only v1_29 feature. we might have to pin k8s-openapi too.
There was a problem hiding this comment.
To avoid unexpected new release caused build problem
|
Thanks! |
Signed-off-by: Derek Wang <[email protected]>
whynowy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
- Coverage 63.22% 63.11% -0.11%
==========================================
Files 319 319
Lines 29171 29171
==========================================
- Hits 18442 18411 -31
- Misses 9717 9748 +31
Partials 1012 1012 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Wang <[email protected]>
KeranYang
approved these changes
Sep 9, 2024
whynowy
added a commit
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
codegenproblem.