Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should never scale down to < min #1832

Merged
merged 2 commits into from
Jul 16, 2024

.

7e09f78
Select commit
Loading
Failed to load commit list.
Merged

fix: should never scale down to < min #1832

.
7e09f78
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 16, 2024 in 1s

52.84% (-0.40%) compared to cea0783

View this Pull Request on Codecov

52.84% (-0.40%) compared to cea0783

Details

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.84%. Comparing base (cea0783) to head (7e09f78).

Files Patch % Lines
pkg/reconciler/vertex/scaling/scaling.go 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
- Coverage   53.24%   52.84%   -0.40%     
==========================================
  Files         282      282              
  Lines       27314    27314              
==========================================
- Hits        14543    14435     -108     
- Misses      11925    12028     +103     
- Partials      846      851       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.