Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should never scale down to < min #1832

Merged
merged 2 commits into from
Jul 16, 2024
Merged

fix: should never scale down to < min #1832

merged 2 commits into from
Jul 16, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Jul 16, 2024

Explain what this PR does.

@whynowy whynowy requested a review from vigith as a code owner July 16, 2024 06:36
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.84%. Comparing base (cea0783) to head (7e09f78).

Files Patch % Lines
pkg/reconciler/vertex/scaling/scaling.go 0.00% 20 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
- Coverage   53.24%   52.84%   -0.40%     
==========================================
  Files         282      282              
  Lines       27314    27314              
==========================================
- Hits        14543    14435     -108     
- Misses      11925    12028     +103     
- Partials      846      851       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whynowy
.
7e09f78 
Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy enabled auto-merge (squash) July 16, 2024 07:05
@whynowy whynowy merged commit fa18f97 into numaproj:main Jul 16, 2024
25 checks passed
whynowy added a commit to whynowy/numaflow that referenced this pull request Jul 16, 2024
@whynowy
fix(numaproj#1832): scale down to >=min, but not 0
b70ba04 
Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy deleted the scalefix branch July 16, 2024 15:52
whynowy added a commit that referenced this pull request Jul 16, 2024
@whynowy
fix(#1832): scale down to >=min, but not 0 when there's direct back p…
6e4a681 
…ressure (#1834)

Signed-off-by: Derek Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhl25 yhl25 yhl25 approved these changes

@vigith vigith Awaiting requested review from vigith vigith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whynowy @yhl25