Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.1.3 #3997

Merged
merged 15 commits into from
Nov 4, 2021
Merged

v8.1.3 #3997

merged 15 commits into from
Nov 4, 2021

Conversation

wraithgar
Copy link
Member

v8.1.3 (2021-11-04)

BUG FIXES

DEPENDENCIES

wraithgar and others added 15 commits November 2, 2021 12:54
Adds a new required checkbox to our bug template directing people to use
the latest npm version to verify their bug still exists.

PR-URL: #3977
Credit: @wraithgar
Close: #3977
Reviewed-by: @darcyclarke
We don't need duplicate builds on pull requests and pushes.  This should
cut our actions essentially down to half of what they are now.

PR-URL: #3981
Credit: @wraithgar
Close: #3981
Reviewed-by: @darcyclarke
Also update with other items from template-oss

PR-URL: #3982
Credit: @lukekarrys
Close: #3982
Reviewed-by: @wraithgar

PR-URL: #3982
Credit: @lukekarrys
Close: #3982
Reviewed-by: @wraithgar

PR-URL: #3982
Credit: @lukekarrys
Close: #3982
Reviewed-by: @wraithgar
This is the first phase of refactoring the internal structure of the npm
commands to set us up for future changes.  This iteration changes the
function signature of `exec` for all the commands to be a async (no more
callbacks), and also groups all the commands into their own
subdirectory.

It also removes the Proxy `npm.commands` object, in favor of an
`npm.cmd` and `npm.exec` function that breaks up the two things that
proxy was doing. Namely, getting to the attributes of a given command
(`npm.cmd` now does this), and actually running the command `npm.exec`
does this.

PR-URL: #3959
Credit: @wraithgar
Close: #3959
Reviewed-by: @lukekarrys
Fix: #3962

When created from a hidden lockfile, shrinkwrap was always setting the
lockfileVersion to 3. The shrinkwrap command also needed to be updated
to log the correct message based on the lockfileVersion config instead
of the static lockfileVersion.

With these fixes, it was possible to log a better message whenever we
are changing the lockfileVersion, either from a config or any existing
lockfile.

Lastly, the tests for shrinkwrap were completely refactored to use the
real npm and test all conceivable scenarios, as well as removing usage
of `util.promisify` in favor of `fs.promises` now that we've dropped
support for Node 10.

PR-URL: #3978
Credit: @lukekarrys
Close: #3978
Reviewed-by: @wraithgar
Now that we make dependency upgrades as pull requests, this should make
them easier to review since GitHub will now render diffs for them by
default.

PR-URL: #3991
Credit: @lukekarrys
Close: #3991
Reviewed-by: @wraithgar
This is safe to do now that we've dropped node 10 support.

PR-URL: #3988
Credit: @lukekarrys
Close: #3988
Reviewed-by: @wraithgar
Windows no longer allows `file://`, but instead requires `file:///` for
local file urls.

Also after the command refactor things shifted and the tests didn't
catch that the help pages didn't work at all anymore, and that the
post-edit rebuild didn't work. This cleans up those two issues.

PR-URL: #3994
Credit: @wraithgar
Close: #3994
Reviewed-by: @lukekarrys
  * fix: dont load project configs in global mode

PR-URL: #3996
Credit: @nlf
Close: #3996
Reviewed-by: @wraithgar

PR-URL: #3996
Credit: @nlf
Close: #3996
Reviewed-by: @wraithgar
@wraithgar wraithgar requested a review from a team as a code owner November 4, 2021 20:20
@wraithgar wraithgar merged commit de45f90 into latest Nov 4, 2021
@nlf nlf deleted the release/v8.1.3 branch March 28, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants