-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8.1.3 #3997
Merged
Merged
v8.1.3 #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new required checkbox to our bug template directing people to use the latest npm version to verify their bug still exists. PR-URL: #3977 Credit: @wraithgar Close: #3977 Reviewed-by: @darcyclarke
We don't need duplicate builds on pull requests and pushes. This should cut our actions essentially down to half of what they are now. PR-URL: #3981 Credit: @wraithgar Close: #3981 Reviewed-by: @darcyclarke
PR-URL: #3958 Credit: @nlf Close: #3958 Reviewed-by: @wraithgar
Also update with other items from template-oss PR-URL: #3982 Credit: @lukekarrys Close: #3982 Reviewed-by: @wraithgar PR-URL: #3982 Credit: @lukekarrys Close: #3982 Reviewed-by: @wraithgar PR-URL: #3982 Credit: @lukekarrys Close: #3982 Reviewed-by: @wraithgar
This is the first phase of refactoring the internal structure of the npm commands to set us up for future changes. This iteration changes the function signature of `exec` for all the commands to be a async (no more callbacks), and also groups all the commands into their own subdirectory. It also removes the Proxy `npm.commands` object, in favor of an `npm.cmd` and `npm.exec` function that breaks up the two things that proxy was doing. Namely, getting to the attributes of a given command (`npm.cmd` now does this), and actually running the command `npm.exec` does this. PR-URL: #3959 Credit: @wraithgar Close: #3959 Reviewed-by: @lukekarrys
Fix: #3962 When created from a hidden lockfile, shrinkwrap was always setting the lockfileVersion to 3. The shrinkwrap command also needed to be updated to log the correct message based on the lockfileVersion config instead of the static lockfileVersion. With these fixes, it was possible to log a better message whenever we are changing the lockfileVersion, either from a config or any existing lockfile. Lastly, the tests for shrinkwrap were completely refactored to use the real npm and test all conceivable scenarios, as well as removing usage of `util.promisify` in favor of `fs.promises` now that we've dropped support for Node 10. PR-URL: #3978 Credit: @lukekarrys Close: #3978 Reviewed-by: @wraithgar
Now that we make dependency upgrades as pull requests, this should make them easier to review since GitHub will now render diffs for them by default. PR-URL: #3991 Credit: @lukekarrys Close: #3991 Reviewed-by: @wraithgar
This is safe to do now that we've dropped node 10 support. PR-URL: #3988 Credit: @lukekarrys Close: #3988 Reviewed-by: @wraithgar
PR-URL: #3990 Credit: @lukekarrys Close: #3990 Reviewed-by: @wraithgar
PR-URL: #3986 Credit: @lukekarrys Close: #3986 Reviewed-by: @wraithgar
Windows no longer allows `file://`, but instead requires `file:///` for local file urls. Also after the command refactor things shifted and the tests didn't catch that the help pages didn't work at all anymore, and that the post-edit rebuild didn't work. This cleans up those two issues. PR-URL: #3994 Credit: @wraithgar Close: #3994 Reviewed-by: @lukekarrys
* fix: dont load project configs in global mode PR-URL: #3996 Credit: @nlf Close: #3996 Reviewed-by: @wraithgar PR-URL: #3996 Credit: @nlf Close: #3996 Reviewed-by: @wraithgar
PR-URL: #3987 Credit: @lukekarrys Close: #3987 Reviewed-by: @wraithgar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8.1.3 (2021-11-04)
BUG FIXES
8ffeb71df
#3959 fix: refactor commands (@wraithgar)e5bfdaca4
#3978 fix: shrinkwrap setting incorrect lockfileVersion (@lukekarrys)32ccd3c27
#3988 fix: remove usage of unnecessary util.promisify (@lukekarrys)1e9c31c4e
#3994 fix: npm help on windows (@wraithgar)22230ef3d
#3987 fix: make prefixed usage errors more consistent (@lukekarrys)DEPENDENCIES
ac2fabb86
#3990@npmcli/[email protected]
a0d35ff20
#3996@npmcli/[email protected]
: