Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: limit CI builds #3981

Merged
merged 1 commit into from
Nov 3, 2021
Merged

chore: limit CI builds #3981

merged 1 commit into from
Nov 3, 2021

Conversation

wraithgar
Copy link
Member

We don't need duplicate builds on pull requests and pushes. This should
cut our actions essentially down to half of what they are now.

@wraithgar wraithgar requested a review from a team as a code owner November 3, 2021 13:58
Copy link
Contributor

@darcyclarke darcyclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great change

@darcyclarke darcyclarke added Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes labels Nov 3, 2021
@wraithgar
Copy link
Member Author

This is already what template-oss does

We don't need duplicate builds on pull requests and pushes.  This should
cut our actions essentially down to half of what they are now.

PR-URL: #3981
Credit: @wraithgar
Close: #3981
Reviewed-by: @darcyclarke
@wraithgar wraithgar merged commit f7a8118 into release-next Nov 3, 2021
@ljharb
Copy link
Contributor

ljharb commented Nov 3, 2021

What about tags?

Often this is done by making PRs from forks instead of the source repo.

@wraithgar
Copy link
Member Author

I don't think we need tests run on tags? We only use them for tagging the release, and those are tested both during the release PR and when in latest. PRs from forks have CI run from the on pull request flag here. You can see it working here as an example npm/are-we-there-yet#116

@wraithgar wraithgar deleted the gar/ci-on-push branch November 3, 2021 16:08
@ljharb
Copy link
Contributor

ljharb commented Nov 3, 2021

Right, but i mean, the only time duplicates are run prior to this PR is when you make a PR from a branch that’s NOT on a fork.

@wraithgar
Copy link
Member Author

Ok sure but we still don't want duplicates run then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants