fix(search): don't pass unused args #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
approved these changes
Mar 1, 2021
wraithgar
added
Release 7.x
The searchopts get parsed and added to the query elsewhere, they're not part of the `include` array they are an extra querystring that is added to the search request. PR-URL: #2803 Credit: @wraithgar Close: #2803 Reviewed-by: @ruyadorno
ruyadorno
force-pushed
the
gar/searchopts
branch
from
25907b1 to
2d682e4
Compare
This was referenced Mar 4, 2021
Merged
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The searchopts get parsed and added to the query elsewhere, they're not
part of the
includearray they are an extra querystring that is addedto the search request.
These already make it to the search request, this was dead code.
References
Closes #2791