Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] search is ignoring --searchopts #2791

Closed
wraithgar opened this issue Feb 27, 2021 · 2 comments · Fixed by #2803
Closed

[BUG] search is ignoring --searchopts #2791

wraithgar opened this issue Feb 27, 2021 · 2 comments · Fixed by #2803
Assignees
Labels
Bug thing that needs fixing Priority 1 high priority issue Release 7.x work is associated with a specific npm 7 release

Comments

@wraithgar
Copy link
Member

wraithgar commented Feb 27, 2021

Current Behavior:

--searchopts is not making it into the options passed to search

Expected Behavior:

--searchopts is added to the options passed into search

Steps To Reproduce:

They are passed into prepareIncludes

include: prepareIncludes(args, npm.flatOptions.search.opts),

And then ignored

cli/lib/search.js

Lines 70 to 74 in 113b131

function prepareIncludes (args, searchopts) {
return args
.map(s => s.toLowerCase())
.filter(s => s)
}

Environment:

npm v7.6.0

@wraithgar wraithgar added Release 7.x work is associated with a specific npm 7 release Bug thing that needs fixing Priority 1 high priority issue labels Feb 27, 2021
@wraithgar wraithgar self-assigned this Feb 27, 2021
@darcyclarke
Copy link
Contributor

Closing as this should have gotten resolved in #2803 (ie. v7.6.1) Please let us know if there are any other issues

@ackvf
Copy link

ackvf commented Oct 23, 2024

Am I doing it wrong? When I do npm search alfons --json --searchopts react --searchlimit 2 it gives exactly same result as npm search alfons --json --searchlimit 2 and the found package isn't even react related.

On the other hand, this gives the expected result npm search alfons react --json --searchlimit 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Priority 1 high priority issue Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants