Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 6.14.4 #1059

Merged
merged 8 commits into from
Mar 25, 2020
Merged

Release 6.14.4 #1059

merged 8 commits into from
Mar 25, 2020

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Mar 24, 2020 •
edited
Loading

6.14.4 (2020-03-24)

DEPENDENCIES

ruyadorno and others added 6 commits March 24, 2020 15:38
@ruyadorno
[email protected]
136832d
@ruyadorno
[email protected]
9c554fd
@ruyadorno
chore: ignore any nested .DS_Store file
b3eb8d5 
PR-URL: #1057
Credit: @ruyadorno
Close: #1057
Reviewed-by: @ruyadorno
@ruyadorno
deps: updates term-size to use signed binary
8bf99b2 
Upstream node is patching `term-size` in order to avoid failing release
builds, see: nodejs/node#32403

Given that npm@6 has to support node6 and that dependency chain is long
enough, along with many major bumps dropping node6 along the way. I
propose we patch it here same as node upstream.

- ref: sindresorhus/terminal-size#16

PR-URL: #1053
Credit: @ruyadorno
Close: #1053
Reviewed-by: @ruyadorno
@isaacs @ruyadorno
Add note about third-party test fixture code
5e75850
@isaacs @ruyadorno
Do not ship CoC/Contributing files for deps
be37961 
Some of these are used under a somewhat ambiguous license, and we're
moving away from the WeAll* stuff to just rely on the centralized npm
code of conduct anyhow.  Better to leave them out for now, as we go
through and update the deps themselves to have a cleaner and more
consistent project setup.

PR-URL: #1054
Credit: @isaacs
Close: #1054
Reviewed-by: @ruyadorno
@ruyadorno ruyadorno requested a review from a team as a code owner March 24, 2020 21:21
@npm-deploy-user
Copy link

npm-deploy-user commented Mar 24, 2020 •
edited
Loading

angular-quickstart app-large app-medium ember-quickstart react-app
prev current status prev current status prev current status prev current status prev current status
initial install 41s 39.1s✅ 39.5s 35.8s✅ 34.5s 30.5s✅ 28.1s 24.9s✅ 33.5s 30.1s✅
repeat install 9.6s 8.4s✅ 8.6s 8s✅ 8.3s 7.7s✅ 7.7s 6.9s✅ 9.1s 8.3s✅
with warm cache 32.3s 27.5s✅ 33.8s 31.9s✅ 31.3s 26.2s✅ 23.4s 19.9s✅ 29.1s 27.8s✅
with node_modules 9.2s 9.1s✅ 8.6s 7s✅ 9s 8s✅ 7.8s 6.3s✅ 9.4s 8.6s✅
with lockfile 32.6s 27.7s✅ 31s 29s✅ 29s 29s✅ 21.7s 17.9s✅ 27.4s 25.4s✅
with warm cache and node_modules 9.3s 8.2s✅ 7.9s 7.6s✅ 8.4s 7.9s✅ 7.6s 8.2s✅🐌 9.2s 7.7s✅
with warm cache and lockfile 24.7s 22.5s✅ 26.3s 26.7s✅🐌 24.3s 20.8s✅ 17.8s 15.3s✅ 21.3s 19.8s✅
with node_modules and lockfile 10.1s 9.2s✅ 9.8s 8.1s✅ 8.6s 7.9s✅ 7.8s 7.1s✅ 9.7s 8.6s✅

@ruyadorno ruyadorno mentioned this pull request Mar 25, 2020
Closed
@ruyadorno
Copy link
Contributor Author

fixes #1027

@ruyadorno ruyadorno merged commit cf7da1e into latest Mar 25, 2020
@mleneveut mleneveut mentioned this pull request Mar 26, 2020
Closed
@isaacs isaacs deleted the release-6.14.4 branch August 19, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruyadorno @npm-deploy-user @isaacs