deps: updates term-size to use signed binary #1053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream node is patching `term-size` in order to avoid failing release builds, see: nodejs/node#32403 Given that npm@6 has to support node6 and that dependency chain is long enough, along with many major bumps dropping node6 along the way. I propose we patch it here same as node upstream. - ref: sindresorhus/terminal-size#16
ruyadorno
added
Release 6.x
|
LGTM! |
|
I suggest that spawning an executable to make an ioctl that can be made through pure js with existing builtin Node.js APIs is not really the way to go, perhaps its worth choosing box drawing dependencies that don't do that? |
Merged
|
@sam-github thanks for bringing that up, we're currently revisiting |
Closed
This was referenced Apr 17, 2020
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream node is patching
term-sizein order to avoid failing release builds, see: nodejs/node#32403Given that npm@6 has to support node 6 and that dependency chain [term-size] is long enough, along with many major bumps dropping node6 along the way. I propose we patch it here same as node downstream.
ref: sindresorhus/terminal-size#16