Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: automatically clear any unwanted directories in test_programs #5081

Merged
merged 3 commits into from
May 22, 2024

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented May 22, 2024

Description

Problem*

Closes #5035

Summary*

Alternative to #5035 which just deletes any test programs which don't have a Nargo.toml file.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from michaeljklein May 22, 2024 16:57
@TomAFrench TomAFrench enabled auto-merge May 22, 2024 20:27
@TomAFrench TomAFrench added this pull request to the merge queue May 22, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 22, 2024
#5081)

# Description

## Problem\*

Closes #5035

## Summary\*

Alternative to #5035 which just deletes any test programs which don't
have a Nargo.toml file.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 22, 2024
@TomAFrench TomAFrench added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit e807f0d May 22, 2024
42 checks passed
@TomAFrench TomAFrench deleted the tf/clear-bad-test-programs branch May 22, 2024 23:36
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request May 23, 2024
chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081)
chore: update `nargo info` table to remove circuit size column
feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080)
fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941)
chore(experimental): Elaborate globals (noir-lang/noir#5069)
chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066)
feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058)
chore: use `bbup` to install `bb` (noir-lang/noir#5073)
feat: Sync from aztec-packages (noir-lang/noir#5070)
chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071)
feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050)
fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request May 27, 2024
…r-lang/noir#5097)

chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107)
chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100)
feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098)
chore: Move turbofish changes to the elaborator (noir-lang/noir#5094)
fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087)
chore: reactivate gates report (noir-lang/noir#5084)
chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081)
chore: update `nargo info` table to remove circuit size column
feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080)
fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941)
chore(experimental): Elaborate globals (noir-lang/noir#5069)
chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066)
feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058)
chore: use `bbup` to install `bb` (noir-lang/noir#5073)
feat: Sync from aztec-packages (noir-lang/noir#5070)
chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071)
feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050)
fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request May 27, 2024
…5097)

chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107)
chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100)
feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098)
chore: Move turbofish changes to the elaborator (noir-lang/noir#5094)
fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087)
chore: reactivate gates report (noir-lang/noir#5084)
chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081)
chore: update `nargo info` table to remove circuit size column
feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080)
fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941)
chore(experimental): Elaborate globals (noir-lang/noir#5069)
chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066)
feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058)
chore: use `bbup` to install `bb` (noir-lang/noir#5073)
feat: Sync from aztec-packages (noir-lang/noir#5070)
chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071)
feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050)
fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)
sirasistant added a commit to AztecProtocol/aztec-packages that referenced this pull request May 27, 2024
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: Consider block parameters in variable liveness
(noir-lang/noir#5097)
chore(docs): Link to evmdiff for supported EVM chains
(noir-lang/noir#5107)
chore: Avoid creating witness for simple multiplications
(noir-lang/noir#5100)
feat: Add intrinsic to get if running inside an unconstrained context
(noir-lang/noir#5098)
chore: Move turbofish changes to the elaborator
(noir-lang/noir#5094)
fix: Apply self type from generic trait constraint before instantiating
identifiers (noir-lang/noir#5087)
chore: reactivate gates report
(noir-lang/noir#5084)
chore: automatically clear any unwanted directories in `test_programs`
(noir-lang/noir#5081)
chore: update `nargo info` table to remove circuit size column
feat: Activate return_data in ACIR opcodes
(noir-lang/noir#5080)
fix: Use plain integer addresses for opcodes in DAP disassembly view
(noir-lang/noir#4941)
chore(experimental): Elaborate globals
(noir-lang/noir#5069)
chore(experimental): Add types and traits to the elaborator
(noir-lang/noir#5066)
feat: remove conditional compilation of `bn254_blackbox_solver`
(noir-lang/noir#5058)
chore: use `bbup` to install `bb`
(noir-lang/noir#5073)
feat: Sync from aztec-packages
(noir-lang/noir#5070)
chore: update docs to represent zksync supporting necessary precompiles
(noir-lang/noir#5071)
feat(stdlib)!: eddsa function using turbofish
(noir-lang/noir#5050)
fix(frontend): Correctly monomorphize turbofish functions
(noir-lang/noir#5049)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Tom French <[email protected]>
Co-authored-by: sirasistant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants