feat: test_programs that are invisible to git now pass
#5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for compile_success_empty, add skipping for compile_failure (skips generating test), add error for this case, catch that error instead of throwing it with a non-zero exit code, add is_package_visible_to_git, add test program w/ .gitignore exception to test this, add expected failure to prevent regressions, add 'target' dir case
|
Discussed in scrum that we can probably simplify this to deleting any folder which don't contain a |
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
#5081) # Description ## Problem\* Closes #5035 ## Summary\* Alternative to #5035 which just deletes any test programs which don't have a Nargo.toml file. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
#5081) # Description ## Problem\* Closes #5035 ## Summary\* Alternative to #5035 which just deletes any test programs which don't have a Nargo.toml file. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves the spurious errors that occur when moving/merging branches and accumulating
test_programspackages that are invisible togit, e.g. they only contain aVerifier.tomlSummary*
Previously, we were failing with ~
No Nargo.toml found, but often we have cases where there are no.nrfiles or other files visible togit. This PR recognizes those cases and skips the running the rest of the CLI command.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.