Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Signed integer comparisons in brillig #4579

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: Signed integer comparisons in brillig #4579

merged 1 commit into from
Mar 19, 2024

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Mar 19, 2024 •
edited
Loading

Description

Problem*

Resolves #4286

Summary*

Fixes signed integer comparison by comparing biased versions of the two operands

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Base automatically changed from aztec-packages to master March 19, 2024 09:34
@sirasistant sirasistant force-pushed the arv/fix_signed_comparisons branch from 10f7934 to 4c504d4 Compare March 19, 2024 09:37
@sirasistant sirasistant marked this pull request as ready for review March 19, 2024 09:38
@vezenovm vezenovm added this pull request to the merge queue Mar 19, 2024
Merged via the queue into master with commit 938d5e8 Mar 19, 2024
43 checks passed
@vezenovm vezenovm deleted the arv/fix_signed_comparisons branch March 19, 2024 14:16
@kevaundray kevaundray mentioned this pull request Mar 19, 2024
Merged
TomAFrench added a commit that referenced this pull request Mar 20, 2024
@TomAFrench
Merge branch 'master' into tf/unsafe-blocks
bb4a45a 
* master: (28 commits)
  chore: fix assignees for opening issues based on CI (#4596)
  feat!: separating out array and slice types in the AST (#4504)
  chore: fix docs builds (#4593)
  chore: Standardise workspace JS dependencies (#4583)
  feat: Add `break` and `continue` in unconstrained code (#4569)
  chore: update deps (#4582)
  fix: Signed integer comparisons in brillig (#4579)
  chore: Add clarfiication on the difference in recursive aggregation circuits (#4567)
  feat: Sync from aztec-packages (#4573)
  fix: added error messages for passing oracles and references from unconstrained to constrained functions (#4570)
  feat: RC optimization pass (#4560)
  feat: add as_slice builtin function, add execution test (#4523)
  chore: making docs build before cutting versions (#4568)
  chore: fix docker test workflows (#4566)
  feat: allow usage of noir `#[test]` syntax in stdlib (#4553)
  feat: Add more impls on Option (#4549)
  chore: fixing some broken links (#4556)
  chore: separate tests for execution failures from compilation failures (#4559)
  feat: remove curly braces with fmt  (#4529)
  fix: Make `nargo` the default binary for cargo run (#4554)
  ...
github-merge-queue bot pushed a commit that referenced this pull request Mar 25, 2024
@kevaundray
chore: Release Noir(0.26.0) (#4526)
c46b164 
🤖 I have created a release *beep* *boop*
---


<details><summary>0.26.0</summary>

## [0.26.0](v0.25.0...v0.26.0)
(2024-03-25)


### ⚠ BREAKING CHANGES

* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
* automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
* separating out array and slice types in the AST
([#4504](#4504))
* Acir call opcode
(AztecProtocol/aztec-packages#4773)
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
* Remove open keyword from Noir
(AztecProtocol/aztec-packages#4967)

### Features

* Acir call opcode
(AztecProtocol/aztec-packages#4773)
([c3c9e19](c3c9e19))
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
([13eb71b](13eb71b))
* Add `break` and `continue` in unconstrained code
([#4569](#4569))
([f2f827d](f2f827d))
* Add `nargo compile --watch` command
([#4464](#4464))
([44e60b6](44e60b6))
* Add as_slice builtin function, add execution test
([#4523](#4523))
([6a9ea35](6a9ea35))
* Add checks for bit size consistency on brillig gen
([#4542](#4542))
([f3243b7](f3243b7))
* Add CMOV instruction to brillig and brillig gen
(AztecProtocol/aztec-packages#5308)
([13eb71b](13eb71b))
* Add experimental `quote` expression to parser
([#4595](#4595))
([4c3a30b](4c3a30b))
* Add more impls on Option
([#4549](#4549))
([4cf700b](4cf700b))
* Add specific error for attempting `string[x] = ".."`
([#4611](#4611))
([ff95fd9](ff95fd9))
* Allow usage of noir `#[test]` syntax in stdlib
([#4553](#4553))
([a8b7cdb](a8b7cdb))
* Automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
([13eb71b](13eb71b))
* **avm:** Brillig CONST of size &gt; u128
(AztecProtocol/aztec-packages#5217)
([c3c9e19](c3c9e19))
* Brillig IR refactor
(AztecProtocol/aztec-packages#5233)
([c3c9e19](c3c9e19))
* Check initialization arguments in constructors
(AztecProtocol/aztec-packages#5144)
([d4213a0](d4213a0))
* Check initializer msg.sender matches deployer from address preimage
(AztecProtocol/aztec-packages#5222)
([c3c9e19](c3c9e19))
* Initial Earthly CI
(AztecProtocol/aztec-packages#5069)
([c3c9e19](c3c9e19))
* Integrated native ACVM
(AztecProtocol/aztec-packages#4903)
([a6016b4](a6016b4))
* Make brillig-gen more AVM-friendly
(AztecProtocol/aztec-packages#5091)
([a6016b4](a6016b4))
* New brillig field operations and refactor of binary operations
(AztecProtocol/aztec-packages#5208)
([c3c9e19](c3c9e19))
* Optimize sha2 implementation
([#4441](#4441))
([80373d6](80373d6))
* RC optimization pass
([#4560](#4560))
([dfa5126](dfa5126))
* Remove curly braces with fmt
([#4529](#4529))
([fe9a437](fe9a437))
* Separating out array and slice types in the AST
([#4504](#4504))
([9a241f9](9a241f9))
* Signed integer division and modulus in brillig gen
(AztecProtocol/aztec-packages#5279)
([c3c9e19](c3c9e19))
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5234)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5286)
([c3c9e19](c3c9e19))
* Visible aliases for nargo commands
([#4453](#4453))
([773cf19](773cf19))


### Bug Fixes

* **acir_gen:** More granular element sizes array check
([#4528](#4528))
([f93d16e](f93d16e))
* Added error messages for passing oracles and references from
unconstrained to constrained functions
([#4570](#4570))
([265bd8b](265bd8b))
* Allow non-integer globals to reference struct methods
([#4490](#4490))
([00d6494](00d6494))
* Dynamic assert messages in brillig
([#4531](#4531))
([e24d3fc](e24d3fc))
* Evaluate operators in globals in types
([#4537](#4537))
([c8aa16b](c8aa16b))
* Make `nargo` the default binary for cargo run
([#4554](#4554))
([de4986e](de4986e))
* Signed integer comparisons in brillig
([#4579](#4579))
([938d5e8](938d5e8))
* **ssa:** Use accurate type during SSA AsSlice simplficiation
([#4610](#4610))
([0473497](0473497))
* Substitute generics when checking the field count of a type
([#4547](#4547))
([eeeebac](eeeebac))


### Miscellaneous Chores

* Remove open keyword from Noir
(AztecProtocol/aztec-packages#4967)
([a6016b4](a6016b4))
</details>

<details><summary>0.42.0</summary>

## [0.42.0](v0.41.0...v0.42.0)
(2024-03-25)


### ⚠ BREAKING CHANGES

* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
* automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
* Acir call opcode
(AztecProtocol/aztec-packages#4773)
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
* move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
* note type ids
(AztecProtocol/aztec-packages#4500)
* rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
* init storage macro
(AztecProtocol/aztec-packages#4200)
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
* Sync commits from `aztec-packages`
([#4144](#4144))
* Breaking changes from aztec-packages
([#3955](#3955))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
* Remove unused methods on ACIR opcodes
([#3841](#3841))
* Remove partial backend feature
([#3805](#3805))

### Features

* Acir call opcode
(AztecProtocol/aztec-packages#4773)
([c3c9e19](c3c9e19))
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
([13eb71b](13eb71b))
* Add bit size to const opcode
(AztecProtocol/aztec-packages#4385)
([158c8ce](158c8ce))
* Add CMOV instruction to brillig and brillig gen
(AztecProtocol/aztec-packages#5308)
([13eb71b](13eb71b))
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
([158c8ce](158c8ce))
* Add instrumentation for tracking variables in debugging
([#4122](#4122))
([c58d691](c58d691))
* Add poseidon2 opcode implementation for acvm/brillig, and Noir
([#4398](#4398))
([10e8292](10e8292))
* Add support for overriding expression width
([#4117](#4117))
([c8026d5](c8026d5))
* Added cast opcode and cast calldata
(AztecProtocol/aztec-packages#4423)
([78ef013](78ef013))
* Allow brillig to read arrays directly from memory
(AztecProtocol/aztec-packages#4460)
([158c8ce](158c8ce))
* Allow nested arrays and vectors in Brillig foreign calls
(AztecProtocol/aztec-packages#4478)
([158c8ce](158c8ce))
* Allow variables and stack trace inspection in the debugger
([#4184](#4184))
([bf263fc](bf263fc))
* Automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
([13eb71b](13eb71b))
* **avm:** Back in avm context with macro - refactor context
(AztecProtocol/aztec-packages#4438)
([158c8ce](158c8ce))
* **avm:** Brillig CONST of size &gt; u128
(AztecProtocol/aztec-packages#5217)
([c3c9e19](c3c9e19))
* **aztec-nr:** Initial work for aztec public vm macro
(AztecProtocol/aztec-packages#4400)
([158c8ce](158c8ce))
* Aztec-packages
([#3754](#3754))
([c043265](c043265))
* Backpropagate constants in ACIR during optimization
([#3926](#3926))
([aad0da0](aad0da0))
* Breaking changes from aztec-packages
([#3955](#3955))
([5be049e](5be049e))
* Brillig IR refactor
(AztecProtocol/aztec-packages#5233)
([c3c9e19](c3c9e19))
* Check initializer msg.sender matches deployer from address preimage
(AztecProtocol/aztec-packages#5222)
([c3c9e19](c3c9e19))
* Evaluation of dynamic assert messages
([#4101](#4101))
([c284e01](c284e01))
* Init storage macro
(AztecProtocol/aztec-packages#4200)
([158c8ce](158c8ce))
* Initial Earthly CI
(AztecProtocol/aztec-packages#5069)
([c3c9e19](c3c9e19))
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
([5f57ebb](5f57ebb))
* New brillig field operations and refactor of binary operations
(AztecProtocol/aztec-packages#5208)
([c3c9e19](c3c9e19))
* Note type ids
(AztecProtocol/aztec-packages#4500)
([78ef013](78ef013))
* Remove range constraints from witnesses which are constrained to be
constants ([#3928](#3928))
([afe9c7a](afe9c7a))
* Remove replacement of boolean range opcodes with `AssertZero` opcodes
([#4107](#4107))
([dac0e87](dac0e87))
* Signed integer division and modulus in brillig gen
(AztecProtocol/aztec-packages#5279)
([c3c9e19](c3c9e19))
* Speed up transformation of debug messages
([#3815](#3815))
([2a8af1e](2a8af1e))
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
([c3c9e19](c3c9e19))
* Sync `aztec-packages`
([#4011](#4011))
([fee2452](fee2452))
* Sync commits from `aztec-packages`
([#4068](#4068))
([7a8f3a3](7a8f3a3))
* Sync commits from `aztec-packages`
([#4144](#4144))
([0205d3b](0205d3b))
* Sync from aztec-packages
([#4483](#4483))
([fe8f277](fe8f277))
* Sync from noir
(AztecProtocol/aztec-packages#5234)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5286)
([c3c9e19](c3c9e19))


### Bug Fixes

* Deserialize odd length hex literals
([#3747](#3747))
([4000fb2](4000fb2))
* Noir test incorrect reporting
(AztecProtocol/aztec-packages#4925)
([5f57ebb](5f57ebb))
* Remove panic from `init_log_level` in `acvm_js`
([#4195](#4195))
([2e26530](2e26530))
* Return error rather instead of panicking on invalid circuit
([#3976](#3976))
([67201bf](67201bf))


### Miscellaneous Chores

* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
([158c8ce](158c8ce))
* Move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
([78ef013](78ef013))
* Remove partial backend feature
([#3805](#3805))
([0383100](0383100))
* Remove unused methods on ACIR opcodes
([#3841](#3841))
([9e5d0e8](9e5d0e8))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
([836f171](836f171))
* Rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
([158c8ce](158c8ce))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
TomAFrench pushed a commit that referenced this pull request Apr 3, 2024
@kevaundray @TomAFrench
chore: Release Noir(0.26.0) (#4526)
435ba1e 
🤖 I have created a release *beep* *boop*
---


<details><summary>0.26.0</summary>

## [0.26.0](v0.25.0...v0.26.0)
(2024-03-25)


### ⚠ BREAKING CHANGES

* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
* automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
* separating out array and slice types in the AST
([#4504](#4504))
* Acir call opcode
(AztecProtocol/aztec-packages#4773)
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
* Remove open keyword from Noir
(AztecProtocol/aztec-packages#4967)

### Features

* Acir call opcode
(AztecProtocol/aztec-packages#4773)
([c3c9e19](c3c9e19))
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
([13eb71b](13eb71b))
* Add `break` and `continue` in unconstrained code
([#4569](#4569))
([f2f827d](f2f827d))
* Add `nargo compile --watch` command
([#4464](#4464))
([44e60b6](44e60b6))
* Add as_slice builtin function, add execution test
([#4523](#4523))
([6a9ea35](6a9ea35))
* Add checks for bit size consistency on brillig gen
([#4542](#4542))
([f3243b7](f3243b7))
* Add CMOV instruction to brillig and brillig gen
(AztecProtocol/aztec-packages#5308)
([13eb71b](13eb71b))
* Add experimental `quote` expression to parser
([#4595](#4595))
([4c3a30b](4c3a30b))
* Add more impls on Option
([#4549](#4549))
([4cf700b](4cf700b))
* Add specific error for attempting `string[x] = ".."`
([#4611](#4611))
([ff95fd9](ff95fd9))
* Allow usage of noir `#[test]` syntax in stdlib
([#4553](#4553))
([a8b7cdb](a8b7cdb))
* Automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
([13eb71b](13eb71b))
* **avm:** Brillig CONST of size &gt; u128
(AztecProtocol/aztec-packages#5217)
([c3c9e19](c3c9e19))
* Brillig IR refactor
(AztecProtocol/aztec-packages#5233)
([c3c9e19](c3c9e19))
* Check initialization arguments in constructors
(AztecProtocol/aztec-packages#5144)
([d4213a0](d4213a0))
* Check initializer msg.sender matches deployer from address preimage
(AztecProtocol/aztec-packages#5222)
([c3c9e19](c3c9e19))
* Initial Earthly CI
(AztecProtocol/aztec-packages#5069)
([c3c9e19](c3c9e19))
* Integrated native ACVM
(AztecProtocol/aztec-packages#4903)
([a6016b4](a6016b4))
* Make brillig-gen more AVM-friendly
(AztecProtocol/aztec-packages#5091)
([a6016b4](a6016b4))
* New brillig field operations and refactor of binary operations
(AztecProtocol/aztec-packages#5208)
([c3c9e19](c3c9e19))
* Optimize sha2 implementation
([#4441](#4441))
([80373d6](80373d6))
* RC optimization pass
([#4560](#4560))
([dfa5126](dfa5126))
* Remove curly braces with fmt
([#4529](#4529))
([fe9a437](fe9a437))
* Separating out array and slice types in the AST
([#4504](#4504))
([9a241f9](9a241f9))
* Signed integer division and modulus in brillig gen
(AztecProtocol/aztec-packages#5279)
([c3c9e19](c3c9e19))
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5234)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5286)
([c3c9e19](c3c9e19))
* Visible aliases for nargo commands
([#4453](#4453))
([773cf19](773cf19))


### Bug Fixes

* **acir_gen:** More granular element sizes array check
([#4528](#4528))
([f93d16e](f93d16e))
* Added error messages for passing oracles and references from
unconstrained to constrained functions
([#4570](#4570))
([265bd8b](265bd8b))
* Allow non-integer globals to reference struct methods
([#4490](#4490))
([00d6494](00d6494))
* Dynamic assert messages in brillig
([#4531](#4531))
([e24d3fc](e24d3fc))
* Evaluate operators in globals in types
([#4537](#4537))
([c8aa16b](c8aa16b))
* Make `nargo` the default binary for cargo run
([#4554](#4554))
([de4986e](de4986e))
* Signed integer comparisons in brillig
([#4579](#4579))
([938d5e8](938d5e8))
* **ssa:** Use accurate type during SSA AsSlice simplficiation
([#4610](#4610))
([0473497](0473497))
* Substitute generics when checking the field count of a type
([#4547](#4547))
([eeeebac](eeeebac))


### Miscellaneous Chores

* Remove open keyword from Noir
(AztecProtocol/aztec-packages#4967)
([a6016b4](a6016b4))
</details>

<details><summary>0.42.0</summary>

## [0.42.0](v0.41.0...v0.42.0)
(2024-03-25)


### ⚠ BREAKING CHANGES

* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
* automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
* Acir call opcode
(AztecProtocol/aztec-packages#4773)
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
* move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
* note type ids
(AztecProtocol/aztec-packages#4500)
* rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
* init storage macro
(AztecProtocol/aztec-packages#4200)
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
* Sync commits from `aztec-packages`
([#4144](#4144))
* Breaking changes from aztec-packages
([#3955](#3955))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
* Remove unused methods on ACIR opcodes
([#3841](#3841))
* Remove partial backend feature
([#3805](#3805))

### Features

* Acir call opcode
(AztecProtocol/aztec-packages#4773)
([c3c9e19](c3c9e19))
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
([13eb71b](13eb71b))
* Add bit size to const opcode
(AztecProtocol/aztec-packages#4385)
([158c8ce](158c8ce))
* Add CMOV instruction to brillig and brillig gen
(AztecProtocol/aztec-packages#5308)
([13eb71b](13eb71b))
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
([158c8ce](158c8ce))
* Add instrumentation for tracking variables in debugging
([#4122](#4122))
([c58d691](c58d691))
* Add poseidon2 opcode implementation for acvm/brillig, and Noir
([#4398](#4398))
([10e8292](10e8292))
* Add support for overriding expression width
([#4117](#4117))
([c8026d5](c8026d5))
* Added cast opcode and cast calldata
(AztecProtocol/aztec-packages#4423)
([78ef013](78ef013))
* Allow brillig to read arrays directly from memory
(AztecProtocol/aztec-packages#4460)
([158c8ce](158c8ce))
* Allow nested arrays and vectors in Brillig foreign calls
(AztecProtocol/aztec-packages#4478)
([158c8ce](158c8ce))
* Allow variables and stack trace inspection in the debugger
([#4184](#4184))
([bf263fc](bf263fc))
* Automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
([13eb71b](13eb71b))
* **avm:** Back in avm context with macro - refactor context
(AztecProtocol/aztec-packages#4438)
([158c8ce](158c8ce))
* **avm:** Brillig CONST of size &gt; u128
(AztecProtocol/aztec-packages#5217)
([c3c9e19](c3c9e19))
* **aztec-nr:** Initial work for aztec public vm macro
(AztecProtocol/aztec-packages#4400)
([158c8ce](158c8ce))
* Aztec-packages
([#3754](#3754))
([c043265](c043265))
* Backpropagate constants in ACIR during optimization
([#3926](#3926))
([aad0da0](aad0da0))
* Breaking changes from aztec-packages
([#3955](#3955))
([5be049e](5be049e))
* Brillig IR refactor
(AztecProtocol/aztec-packages#5233)
([c3c9e19](c3c9e19))
* Check initializer msg.sender matches deployer from address preimage
(AztecProtocol/aztec-packages#5222)
([c3c9e19](c3c9e19))
* Evaluation of dynamic assert messages
([#4101](#4101))
([c284e01](c284e01))
* Init storage macro
(AztecProtocol/aztec-packages#4200)
([158c8ce](158c8ce))
* Initial Earthly CI
(AztecProtocol/aztec-packages#5069)
([c3c9e19](c3c9e19))
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
([5f57ebb](5f57ebb))
* New brillig field operations and refactor of binary operations
(AztecProtocol/aztec-packages#5208)
([c3c9e19](c3c9e19))
* Note type ids
(AztecProtocol/aztec-packages#4500)
([78ef013](78ef013))
* Remove range constraints from witnesses which are constrained to be
constants ([#3928](#3928))
([afe9c7a](afe9c7a))
* Remove replacement of boolean range opcodes with `AssertZero` opcodes
([#4107](#4107))
([dac0e87](dac0e87))
* Signed integer division and modulus in brillig gen
(AztecProtocol/aztec-packages#5279)
([c3c9e19](c3c9e19))
* Speed up transformation of debug messages
([#3815](#3815))
([2a8af1e](2a8af1e))
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
([c3c9e19](c3c9e19))
* Sync `aztec-packages`
([#4011](#4011))
([fee2452](fee2452))
* Sync commits from `aztec-packages`
([#4068](#4068))
([7a8f3a3](7a8f3a3))
* Sync commits from `aztec-packages`
([#4144](#4144))
([0205d3b](0205d3b))
* Sync from aztec-packages
([#4483](#4483))
([fe8f277](fe8f277))
* Sync from noir
(AztecProtocol/aztec-packages#5234)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5286)
([c3c9e19](c3c9e19))


### Bug Fixes

* Deserialize odd length hex literals
([#3747](#3747))
([4000fb2](4000fb2))
* Noir test incorrect reporting
(AztecProtocol/aztec-packages#4925)
([5f57ebb](5f57ebb))
* Remove panic from `init_log_level` in `acvm_js`
([#4195](#4195))
([2e26530](2e26530))
* Return error rather instead of panicking on invalid circuit
([#3976](#3976))
([67201bf](67201bf))


### Miscellaneous Chores

* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
([158c8ce](158c8ce))
* Move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
([78ef013](78ef013))
* Remove partial backend feature
([#3805](#3805))
([0383100](0383100))
* Remove unused methods on ACIR opcodes
([#3841](#3841))
([9e5d0e8](9e5d0e8))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
([836f171](836f171))
* Rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
([158c8ce](158c8ce))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm approved these changes

@jfecher jfecher jfecher approved these changes

@TomAFrench TomAFrench Awaiting requested review from TomAFrench

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signed comparison broken in Brillig
3 participants
@sirasistant @jfecher @vezenovm