Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: separating out array and slice types in the AST #4504

Merged
merged 36 commits into from
Mar 19, 2024

Conversation

michaeljklein
Copy link
Contributor

@michaeljklein michaeljklein commented Mar 7, 2024

Description

Replacement for #4232. Holding off on closing it to possibly port fixes from it, but wanted to start fresh because this approach is quite different.

Problem*

Resolves #4220

Summary*

  • Removes NotConstant
  • Separate syntax for slice literals: &[..]
  • Separate AST/type constructors for slices

Notes:

  • I removed several broken links that were blocking updating the docs:
    • A few were to a missing reference docs folder, likely from an in-progress branch
    • One was to some base_order_curve, which has been moved to reference the BigInt struct

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed over the type system portion but didn't find a reason for the failing example you gave me yet

compiler/noirc_frontend/src/hir_def/types.rs Outdated Show resolved Hide resolved
compiler/noirc_frontend/src/hir_def/types.rs Outdated Show resolved Hide resolved
compiler/noirc_frontend/src/hir/type_check/expr.rs Outdated Show resolved Hide resolved
@jfecher
Copy link
Contributor

jfecher commented Mar 7, 2024

Actually, just looked at the error message in that example more closely. It looks like somewhere the argument order for Type::Array was reversed

jfecher and others added 6 commits March 7, 2024 12:53
…ersand, updating stdlib, fixed nested slice for new type, found missing unification case, added more specific error for missing array length, debugging slice parser, added noirc_frontend test for slices, debugging stdlib failing to build
…type check case, updating test_programs, defaulting unknown array length to zero, cleanup debugging println, add utf8 decoding and serde error to execution json decoding error message, cargo clippy/fmt
…es for slices, fix slice literal in regression test
@michaeljklein michaeljklein changed the title wip: separating out array and slice types in the AST feat: separating out array and slice types in the AST Mar 11, 2024
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the stdlib files but haven't finished going through the compiler changes yet

noir_stdlib/src/merkle.nr Outdated Show resolved Hide resolved
noir_stdlib/src/cmp.nr Outdated Show resolved Hide resolved
noir_stdlib/src/cmp.nr Outdated Show resolved Hide resolved
compiler/noirc_frontend/src/tests.rs Outdated Show resolved Hide resolved
@vezenovm
Copy link
Contributor

@jfecher What do we think about using as_slice() for slice literals rather than &[]. Do we think that syntax will be confusing for users with us not supporting immutable references?

github-merge-queue bot pushed a commit that referenced this pull request Mar 15, 2024
# Description

## Problem\*

Expected to resolve slowdown in
#4504

## Summary\*

Adds builtin function for `as_slice`, allowing it to be much more
efficient (`O(1)` instead of `O(n)`)

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: vezenovm <[email protected]>
Copy link
Contributor

FYI @noir-lang/developerrelations on Noir doc changes.

@jfecher jfecher changed the title feat: separating out array and slice types in the AST feat!: separating out array and slice types in the AST Mar 19, 2024
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jfecher jfecher enabled auto-merge March 19, 2024 19:52
@jfecher jfecher added this pull request to the merge queue Mar 19, 2024
Merged via the queue into master with commit 9a241f9 Mar 19, 2024
45 checks passed
@jfecher jfecher deleted the michaeljklein/separate-slice-ast branch March 19, 2024 20:50
TomAFrench added a commit that referenced this pull request Mar 20, 2024
* master: (28 commits)
  chore: fix assignees for opening issues based on CI (#4596)
  feat!: separating out array and slice types in the AST (#4504)
  chore: fix docs builds (#4593)
  chore: Standardise workspace JS dependencies (#4583)
  feat: Add `break` and `continue` in unconstrained code (#4569)
  chore: update deps (#4582)
  fix: Signed integer comparisons in brillig (#4579)
  chore: Add clarfiication on the difference in recursive aggregation circuits (#4567)
  feat: Sync from aztec-packages (#4573)
  fix: added error messages for passing oracles and references from unconstrained to constrained functions (#4570)
  feat: RC optimization pass (#4560)
  feat: add as_slice builtin function, add execution test (#4523)
  chore: making docs build before cutting versions (#4568)
  chore: fix docker test workflows (#4566)
  feat: allow usage of noir `#[test]` syntax in stdlib (#4553)
  feat: Add more impls on Option (#4549)
  chore: fixing some broken links (#4556)
  chore: separate tests for execution failures from compilation failures (#4559)
  feat: remove curly braces with fmt  (#4529)
  fix: Make `nargo` the default binary for cargo run (#4554)
  ...
github-merge-queue bot pushed a commit that referenced this pull request Mar 20, 2024
# Description

## Problem\*

Resolves #2540

## Summary\*

Fixed in #4504

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
github-merge-queue bot pushed a commit that referenced this pull request Mar 25, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>0.26.0</summary>

## [0.26.0](v0.25.0...v0.26.0)
(2024-03-25)


### ⚠ BREAKING CHANGES

* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
* automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
* separating out array and slice types in the AST
([#4504](#4504))
* Acir call opcode
(AztecProtocol/aztec-packages#4773)
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
* Remove open keyword from Noir
(AztecProtocol/aztec-packages#4967)

### Features

* Acir call opcode
(AztecProtocol/aztec-packages#4773)
([c3c9e19](c3c9e19))
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
([13eb71b](13eb71b))
* Add `break` and `continue` in unconstrained code
([#4569](#4569))
([f2f827d](f2f827d))
* Add `nargo compile --watch` command
([#4464](#4464))
([44e60b6](44e60b6))
* Add as_slice builtin function, add execution test
([#4523](#4523))
([6a9ea35](6a9ea35))
* Add checks for bit size consistency on brillig gen
([#4542](#4542))
([f3243b7](f3243b7))
* Add CMOV instruction to brillig and brillig gen
(AztecProtocol/aztec-packages#5308)
([13eb71b](13eb71b))
* Add experimental `quote` expression to parser
([#4595](#4595))
([4c3a30b](4c3a30b))
* Add more impls on Option
([#4549](#4549))
([4cf700b](4cf700b))
* Add specific error for attempting `string[x] = ".."`
([#4611](#4611))
([ff95fd9](ff95fd9))
* Allow usage of noir `#[test]` syntax in stdlib
([#4553](#4553))
([a8b7cdb](a8b7cdb))
* Automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
([13eb71b](13eb71b))
* **avm:** Brillig CONST of size &gt; u128
(AztecProtocol/aztec-packages#5217)
([c3c9e19](c3c9e19))
* Brillig IR refactor
(AztecProtocol/aztec-packages#5233)
([c3c9e19](c3c9e19))
* Check initialization arguments in constructors
(AztecProtocol/aztec-packages#5144)
([d4213a0](d4213a0))
* Check initializer msg.sender matches deployer from address preimage
(AztecProtocol/aztec-packages#5222)
([c3c9e19](c3c9e19))
* Initial Earthly CI
(AztecProtocol/aztec-packages#5069)
([c3c9e19](c3c9e19))
* Integrated native ACVM
(AztecProtocol/aztec-packages#4903)
([a6016b4](a6016b4))
* Make brillig-gen more AVM-friendly
(AztecProtocol/aztec-packages#5091)
([a6016b4](a6016b4))
* New brillig field operations and refactor of binary operations
(AztecProtocol/aztec-packages#5208)
([c3c9e19](c3c9e19))
* Optimize sha2 implementation
([#4441](#4441))
([80373d6](80373d6))
* RC optimization pass
([#4560](#4560))
([dfa5126](dfa5126))
* Remove curly braces with fmt
([#4529](#4529))
([fe9a437](fe9a437))
* Separating out array and slice types in the AST
([#4504](#4504))
([9a241f9](9a241f9))
* Signed integer division and modulus in brillig gen
(AztecProtocol/aztec-packages#5279)
([c3c9e19](c3c9e19))
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5234)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5286)
([c3c9e19](c3c9e19))
* Visible aliases for nargo commands
([#4453](#4453))
([773cf19](773cf19))


### Bug Fixes

* **acir_gen:** More granular element sizes array check
([#4528](#4528))
([f93d16e](f93d16e))
* Added error messages for passing oracles and references from
unconstrained to constrained functions
([#4570](#4570))
([265bd8b](265bd8b))
* Allow non-integer globals to reference struct methods
([#4490](#4490))
([00d6494](00d6494))
* Dynamic assert messages in brillig
([#4531](#4531))
([e24d3fc](e24d3fc))
* Evaluate operators in globals in types
([#4537](#4537))
([c8aa16b](c8aa16b))
* Make `nargo` the default binary for cargo run
([#4554](#4554))
([de4986e](de4986e))
* Signed integer comparisons in brillig
([#4579](#4579))
([938d5e8](938d5e8))
* **ssa:** Use accurate type during SSA AsSlice simplficiation
([#4610](#4610))
([0473497](0473497))
* Substitute generics when checking the field count of a type
([#4547](#4547))
([eeeebac](eeeebac))


### Miscellaneous Chores

* Remove open keyword from Noir
(AztecProtocol/aztec-packages#4967)
([a6016b4](a6016b4))
</details>

<details><summary>0.42.0</summary>

## [0.42.0](v0.41.0...v0.42.0)
(2024-03-25)


### ⚠ BREAKING CHANGES

* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
* automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
* Acir call opcode
(AztecProtocol/aztec-packages#4773)
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
* move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
* note type ids
(AztecProtocol/aztec-packages#4500)
* rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
* init storage macro
(AztecProtocol/aztec-packages#4200)
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
* Sync commits from `aztec-packages`
([#4144](#4144))
* Breaking changes from aztec-packages
([#3955](#3955))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
* Remove unused methods on ACIR opcodes
([#3841](#3841))
* Remove partial backend feature
([#3805](#3805))

### Features

* Acir call opcode
(AztecProtocol/aztec-packages#4773)
([c3c9e19](c3c9e19))
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
([13eb71b](13eb71b))
* Add bit size to const opcode
(AztecProtocol/aztec-packages#4385)
([158c8ce](158c8ce))
* Add CMOV instruction to brillig and brillig gen
(AztecProtocol/aztec-packages#5308)
([13eb71b](13eb71b))
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
([158c8ce](158c8ce))
* Add instrumentation for tracking variables in debugging
([#4122](#4122))
([c58d691](c58d691))
* Add poseidon2 opcode implementation for acvm/brillig, and Noir
([#4398](#4398))
([10e8292](10e8292))
* Add support for overriding expression width
([#4117](#4117))
([c8026d5](c8026d5))
* Added cast opcode and cast calldata
(AztecProtocol/aztec-packages#4423)
([78ef013](78ef013))
* Allow brillig to read arrays directly from memory
(AztecProtocol/aztec-packages#4460)
([158c8ce](158c8ce))
* Allow nested arrays and vectors in Brillig foreign calls
(AztecProtocol/aztec-packages#4478)
([158c8ce](158c8ce))
* Allow variables and stack trace inspection in the debugger
([#4184](#4184))
([bf263fc](bf263fc))
* Automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
([13eb71b](13eb71b))
* **avm:** Back in avm context with macro - refactor context
(AztecProtocol/aztec-packages#4438)
([158c8ce](158c8ce))
* **avm:** Brillig CONST of size &gt; u128
(AztecProtocol/aztec-packages#5217)
([c3c9e19](c3c9e19))
* **aztec-nr:** Initial work for aztec public vm macro
(AztecProtocol/aztec-packages#4400)
([158c8ce](158c8ce))
* Aztec-packages
([#3754](#3754))
([c043265](c043265))
* Backpropagate constants in ACIR during optimization
([#3926](#3926))
([aad0da0](aad0da0))
* Breaking changes from aztec-packages
([#3955](#3955))
([5be049e](5be049e))
* Brillig IR refactor
(AztecProtocol/aztec-packages#5233)
([c3c9e19](c3c9e19))
* Check initializer msg.sender matches deployer from address preimage
(AztecProtocol/aztec-packages#5222)
([c3c9e19](c3c9e19))
* Evaluation of dynamic assert messages
([#4101](#4101))
([c284e01](c284e01))
* Init storage macro
(AztecProtocol/aztec-packages#4200)
([158c8ce](158c8ce))
* Initial Earthly CI
(AztecProtocol/aztec-packages#5069)
([c3c9e19](c3c9e19))
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
([5f57ebb](5f57ebb))
* New brillig field operations and refactor of binary operations
(AztecProtocol/aztec-packages#5208)
([c3c9e19](c3c9e19))
* Note type ids
(AztecProtocol/aztec-packages#4500)
([78ef013](78ef013))
* Remove range constraints from witnesses which are constrained to be
constants ([#3928](#3928))
([afe9c7a](afe9c7a))
* Remove replacement of boolean range opcodes with `AssertZero` opcodes
([#4107](#4107))
([dac0e87](dac0e87))
* Signed integer division and modulus in brillig gen
(AztecProtocol/aztec-packages#5279)
([c3c9e19](c3c9e19))
* Speed up transformation of debug messages
([#3815](#3815))
([2a8af1e](2a8af1e))
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
([c3c9e19](c3c9e19))
* Sync `aztec-packages`
([#4011](#4011))
([fee2452](fee2452))
* Sync commits from `aztec-packages`
([#4068](#4068))
([7a8f3a3](7a8f3a3))
* Sync commits from `aztec-packages`
([#4144](#4144))
([0205d3b](0205d3b))
* Sync from aztec-packages
([#4483](#4483))
([fe8f277](fe8f277))
* Sync from noir
(AztecProtocol/aztec-packages#5234)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5286)
([c3c9e19](c3c9e19))


### Bug Fixes

* Deserialize odd length hex literals
([#3747](#3747))
([4000fb2](4000fb2))
* Noir test incorrect reporting
(AztecProtocol/aztec-packages#4925)
([5f57ebb](5f57ebb))
* Remove panic from `init_log_level` in `acvm_js`
([#4195](#4195))
([2e26530](2e26530))
* Return error rather instead of panicking on invalid circuit
([#3976](#3976))
([67201bf](67201bf))


### Miscellaneous Chores

* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
([158c8ce](158c8ce))
* Move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
([78ef013](78ef013))
* Remove partial backend feature
([#3805](#3805))
([0383100](0383100))
* Remove unused methods on ACIR opcodes
([#3841](#3841))
([9e5d0e8](9e5d0e8))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
([836f171](836f171))
* Rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
([158c8ce](158c8ce))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
TomAFrench pushed a commit that referenced this pull request Apr 3, 2024
# Description

Replacement for #4232. Holding off
on closing it to possibly port fixes from it, but wanted to start fresh
because this approach is quite different.

## Problem\*

Resolves #4220

## Summary\*

- Removes `NotConstant`
- Separate syntax for slice literals: `&[..]`
- Separate AST/type constructors for slices

Notes:
- I removed several broken links that were blocking updating the docs:
+ A few were to a missing `reference` docs folder, likely from an
in-progress branch
+ One was to some `base_order_curve`, which has been moved to reference
the `BigInt` struct

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Jake Fecher <[email protected]>
Co-authored-by: jfecher <[email protected]>
TomAFrench pushed a commit that referenced this pull request Apr 3, 2024
# Description

## Problem\*

Resolves #2540

## Summary\*

Fixed in #4504

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
TomAFrench pushed a commit that referenced this pull request Apr 3, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>0.26.0</summary>

## [0.26.0](v0.25.0...v0.26.0)
(2024-03-25)


### ⚠ BREAKING CHANGES

* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
* automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
* separating out array and slice types in the AST
([#4504](#4504))
* Acir call opcode
(AztecProtocol/aztec-packages#4773)
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
* Remove open keyword from Noir
(AztecProtocol/aztec-packages#4967)

### Features

* Acir call opcode
(AztecProtocol/aztec-packages#4773)
([c3c9e19](c3c9e19))
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
([13eb71b](13eb71b))
* Add `break` and `continue` in unconstrained code
([#4569](#4569))
([f2f827d](f2f827d))
* Add `nargo compile --watch` command
([#4464](#4464))
([44e60b6](44e60b6))
* Add as_slice builtin function, add execution test
([#4523](#4523))
([6a9ea35](6a9ea35))
* Add checks for bit size consistency on brillig gen
([#4542](#4542))
([f3243b7](f3243b7))
* Add CMOV instruction to brillig and brillig gen
(AztecProtocol/aztec-packages#5308)
([13eb71b](13eb71b))
* Add experimental `quote` expression to parser
([#4595](#4595))
([4c3a30b](4c3a30b))
* Add more impls on Option
([#4549](#4549))
([4cf700b](4cf700b))
* Add specific error for attempting `string[x] = ".."`
([#4611](#4611))
([ff95fd9](ff95fd9))
* Allow usage of noir `#[test]` syntax in stdlib
([#4553](#4553))
([a8b7cdb](a8b7cdb))
* Automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
([13eb71b](13eb71b))
* **avm:** Brillig CONST of size &gt; u128
(AztecProtocol/aztec-packages#5217)
([c3c9e19](c3c9e19))
* Brillig IR refactor
(AztecProtocol/aztec-packages#5233)
([c3c9e19](c3c9e19))
* Check initialization arguments in constructors
(AztecProtocol/aztec-packages#5144)
([d4213a0](d4213a0))
* Check initializer msg.sender matches deployer from address preimage
(AztecProtocol/aztec-packages#5222)
([c3c9e19](c3c9e19))
* Initial Earthly CI
(AztecProtocol/aztec-packages#5069)
([c3c9e19](c3c9e19))
* Integrated native ACVM
(AztecProtocol/aztec-packages#4903)
([a6016b4](a6016b4))
* Make brillig-gen more AVM-friendly
(AztecProtocol/aztec-packages#5091)
([a6016b4](a6016b4))
* New brillig field operations and refactor of binary operations
(AztecProtocol/aztec-packages#5208)
([c3c9e19](c3c9e19))
* Optimize sha2 implementation
([#4441](#4441))
([80373d6](80373d6))
* RC optimization pass
([#4560](#4560))
([dfa5126](dfa5126))
* Remove curly braces with fmt
([#4529](#4529))
([fe9a437](fe9a437))
* Separating out array and slice types in the AST
([#4504](#4504))
([9a241f9](9a241f9))
* Signed integer division and modulus in brillig gen
(AztecProtocol/aztec-packages#5279)
([c3c9e19](c3c9e19))
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5234)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5286)
([c3c9e19](c3c9e19))
* Visible aliases for nargo commands
([#4453](#4453))
([773cf19](773cf19))


### Bug Fixes

* **acir_gen:** More granular element sizes array check
([#4528](#4528))
([f93d16e](f93d16e))
* Added error messages for passing oracles and references from
unconstrained to constrained functions
([#4570](#4570))
([265bd8b](265bd8b))
* Allow non-integer globals to reference struct methods
([#4490](#4490))
([00d6494](00d6494))
* Dynamic assert messages in brillig
([#4531](#4531))
([e24d3fc](e24d3fc))
* Evaluate operators in globals in types
([#4537](#4537))
([c8aa16b](c8aa16b))
* Make `nargo` the default binary for cargo run
([#4554](#4554))
([de4986e](de4986e))
* Signed integer comparisons in brillig
([#4579](#4579))
([938d5e8](938d5e8))
* **ssa:** Use accurate type during SSA AsSlice simplficiation
([#4610](#4610))
([0473497](0473497))
* Substitute generics when checking the field count of a type
([#4547](#4547))
([eeeebac](eeeebac))


### Miscellaneous Chores

* Remove open keyword from Noir
(AztecProtocol/aztec-packages#4967)
([a6016b4](a6016b4))
</details>

<details><summary>0.42.0</summary>

## [0.42.0](v0.41.0...v0.42.0)
(2024-03-25)


### ⚠ BREAKING CHANGES

* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
* automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
* Acir call opcode
(AztecProtocol/aztec-packages#4773)
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
* move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
* note type ids
(AztecProtocol/aztec-packages#4500)
* rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
* init storage macro
(AztecProtocol/aztec-packages#4200)
* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
* Sync commits from `aztec-packages`
([#4144](#4144))
* Breaking changes from aztec-packages
([#3955](#3955))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
* Remove unused methods on ACIR opcodes
([#3841](#3841))
* Remove partial backend feature
([#3805](#3805))

### Features

* Acir call opcode
(AztecProtocol/aztec-packages#4773)
([c3c9e19](c3c9e19))
* **acir:** Program and witness stack structure
(AztecProtocol/aztec-packages#5149)
([13eb71b](13eb71b))
* Add bit size to const opcode
(AztecProtocol/aztec-packages#4385)
([158c8ce](158c8ce))
* Add CMOV instruction to brillig and brillig gen
(AztecProtocol/aztec-packages#5308)
([13eb71b](13eb71b))
* Add expression width into acir
(AztecProtocol/aztec-packages#4014)
([158c8ce](158c8ce))
* Add instrumentation for tracking variables in debugging
([#4122](#4122))
([c58d691](c58d691))
* Add poseidon2 opcode implementation for acvm/brillig, and Noir
([#4398](#4398))
([10e8292](10e8292))
* Add support for overriding expression width
([#4117](#4117))
([c8026d5](c8026d5))
* Added cast opcode and cast calldata
(AztecProtocol/aztec-packages#4423)
([78ef013](78ef013))
* Allow brillig to read arrays directly from memory
(AztecProtocol/aztec-packages#4460)
([158c8ce](158c8ce))
* Allow nested arrays and vectors in Brillig foreign calls
(AztecProtocol/aztec-packages#4478)
([158c8ce](158c8ce))
* Allow variables and stack trace inspection in the debugger
([#4184](#4184))
([bf263fc](bf263fc))
* Automatic NoteInterface and NoteGetterOptions auto select
(AztecProtocol/aztec-packages#4508)
([13eb71b](13eb71b))
* **avm:** Back in avm context with macro - refactor context
(AztecProtocol/aztec-packages#4438)
([158c8ce](158c8ce))
* **avm:** Brillig CONST of size &gt; u128
(AztecProtocol/aztec-packages#5217)
([c3c9e19](c3c9e19))
* **aztec-nr:** Initial work for aztec public vm macro
(AztecProtocol/aztec-packages#4400)
([158c8ce](158c8ce))
* Aztec-packages
([#3754](#3754))
([c043265](c043265))
* Backpropagate constants in ACIR during optimization
([#3926](#3926))
([aad0da0](aad0da0))
* Breaking changes from aztec-packages
([#3955](#3955))
([5be049e](5be049e))
* Brillig IR refactor
(AztecProtocol/aztec-packages#5233)
([c3c9e19](c3c9e19))
* Check initializer msg.sender matches deployer from address preimage
(AztecProtocol/aztec-packages#5222)
([c3c9e19](c3c9e19))
* Evaluation of dynamic assert messages
([#4101](#4101))
([c284e01](c284e01))
* Init storage macro
(AztecProtocol/aztec-packages#4200)
([158c8ce](158c8ce))
* Initial Earthly CI
(AztecProtocol/aztec-packages#5069)
([c3c9e19](c3c9e19))
* Internal as a macro
(AztecProtocol/aztec-packages#4898)
([5f57ebb](5f57ebb))
* New brillig field operations and refactor of binary operations
(AztecProtocol/aztec-packages#5208)
([c3c9e19](c3c9e19))
* Note type ids
(AztecProtocol/aztec-packages#4500)
([78ef013](78ef013))
* Remove range constraints from witnesses which are constrained to be
constants ([#3928](#3928))
([afe9c7a](afe9c7a))
* Remove replacement of boolean range opcodes with `AssertZero` opcodes
([#4107](#4107))
([dac0e87](dac0e87))
* Signed integer division and modulus in brillig gen
(AztecProtocol/aztec-packages#5279)
([c3c9e19](c3c9e19))
* Speed up transformation of debug messages
([#3815](#3815))
([2a8af1e](2a8af1e))
* Support contracts with no constructor
(AztecProtocol/aztec-packages#5175)
([c3c9e19](c3c9e19))
* Sync `aztec-packages`
([#4011](#4011))
([fee2452](fee2452))
* Sync commits from `aztec-packages`
([#4068](#4068))
([7a8f3a3](7a8f3a3))
* Sync commits from `aztec-packages`
([#4144](#4144))
([0205d3b](0205d3b))
* Sync from aztec-packages
([#4483](#4483))
([fe8f277](fe8f277))
* Sync from noir
(AztecProtocol/aztec-packages#5234)
([c3c9e19](c3c9e19))
* Sync from noir
(AztecProtocol/aztec-packages#5286)
([c3c9e19](c3c9e19))


### Bug Fixes

* Deserialize odd length hex literals
([#3747](#3747))
([4000fb2](4000fb2))
* Noir test incorrect reporting
(AztecProtocol/aztec-packages#4925)
([5f57ebb](5f57ebb))
* Remove panic from `init_log_level` in `acvm_js`
([#4195](#4195))
([2e26530](2e26530))
* Return error rather instead of panicking on invalid circuit
([#3976](#3976))
([67201bf](67201bf))


### Miscellaneous Chores

* **acir:** Move `is_recursive` flag to be part of the circuit
definition (AztecProtocol/aztec-packages#4221)
([158c8ce](158c8ce))
* Move noir out of yarn-project
(AztecProtocol/aztec-packages#4479)
([78ef013](78ef013))
* Remove partial backend feature
([#3805](#3805))
([0383100](0383100))
* Remove unused methods on ACIR opcodes
([#3841](#3841))
([9e5d0e8](9e5d0e8))
* Rename Arithmetic opcode to AssertZero
([#3840](#3840))
([836f171](836f171))
* Rename bigint_neg into bigint_sub
(AztecProtocol/aztec-packages#4420)
([158c8ce](158c8ce))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling map on a slice panics
3 participants