feat: support binary data in cloudevents #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on: cloudevents/sdk-javascript#468 Fixes: nodeshift#64 Signed-off-by: Lance Ball <[email protected]>
Signed-off-by: Lance Ball <[email protected]>
|
@lance is knative.gz used somewhere? |
@matejvasek I had a test for it which was failing. I forgot to remove the fixture file. I'm digging into why it's failing. It looks like it's logic in the test framework here that converts the gzip binary data to string. So, I think that gzip should work in practice, just not in tests. EDIT: I created a PR in the test framework. ladjs/superagent#1682 |
|
/lgtm |
matejvasek
approved these changes
Feb 8, 2022
lholmquist
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: cloudevents/sdk-javascript#468
Fixes: #64
Signed-off-by: Lance Ball [email protected]