Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modifies the data type detection logic for json-seq #1682

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

lance
Copy link
Contributor

@lance lance commented Feb 4, 2022

Fixes: #1681

Signed-off-by: Lance Ball [email protected]

@lance lance force-pushed the 1681-parse-json-seq-as-text branch 2 times, most recently from 4c4b046 to 8c07f86 Compare February 4, 2022 17:23
@niftylettuce
Copy link
Collaborator

ping me when ready and if you can add some tests if needed as well?

@lance lance marked this pull request as draft February 4, 2022 19:32
@lance lance force-pushed the 1681-parse-json-seq-as-text branch from 8c07f86 to 42b5231 Compare February 4, 2022 21:11
@lance lance marked this pull request as ready for review February 4, 2022 21:12
@lance
Copy link
Contributor Author

lance commented Feb 4, 2022

@niftylettuce I suppose this is ready for review. I'm not crazy about the implementation. There is definitely some overlap between the use of exports.js and the renamed isBinary() function. That was already the case, and I had a bit of a hard time determining which was the best way to solve this issue. Some refactoring of these two bits might make it easier to provide the ability for developers to declare the desired behavior - or at least consolidate some of the data format guessing game. But that's a bigger change than I am willing to get into. The fix provided in this PR really only addresses my personal use case and perhaps a couple of others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary response data parsed as text
3 participants