Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node v7.7.2 build #262

Merged
merged 7 commits into from
Mar 14, 2017
Merged

node v7.7.2 build #262

merged 7 commits into from
Mar 14, 2017

Conversation

mcollina
Copy link
Member

The build process was ignoring some tests because there are more than 1000 tests now in Node.js and the GitHub UI can only render 1000 files. I have redone the build step to download the source from https://nodejs.org/dist.

Includes #255 and #253.

@mcollina mcollina requested a review from calvinmetcalf March 11, 2017 18:22
@mcollina mcollina mentioned this pull request Mar 13, 2017
6 tasks
@calvinmetcalf
Copy link
Contributor

just got back from vacation, will take a look

@calvinmetcalf
Copy link
Contributor

ok I removed the android stuff so the build passes, I'd love to reenable it but Im not sure how

@mcollina
Copy link
Member Author

I'm happy to get this out of the door :).

Copy link
Contributor

@calvinmetcalf calvinmetcalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mcollina
Copy link
Member Author

@calvinmetcalf you are the only one of us with npm ownership :). So go ahead.

@calvinmetcalf calvinmetcalf merged commit 7af74b0 into master Mar 14, 2017
@calvinmetcalf calvinmetcalf deleted the march-2017 branch March 14, 2017 13:29
@mcollina
Copy link
Member Author

I'm also happy to do it, if you want to give me publish rights :).

@calvinmetcalf
Copy link
Contributor

published it myself but gave you ownership for the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants