-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-add WriteReq and CorkedRequest constructors #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
so once nodejs/node#10558 lands I'll try merging in this and #253 |
so I've got a couple questions
have been out of the loop the last week or 2 so sorry if this has been answered already |
Only most recent versions
It will cause a slowdown for older node versions. |
Part of #262 |
Merging this have been a mistake. This should be merged when Node.js hits v8.0.0, as the the HTTP changes lands. |
@mcollina there is a merge conflict here, can you rebase it ? |
we need this for #290. I'll see what I can do but I am traveling this week. |
ok I can probably do it too, I'm not 100% on it though like how many libraries are using corked writable streams in the hot path and in older node using readable-streams. Wouldn't they also be having similar if not bigger performance issues from using that older node and they'd get bigger benefits from upgrading ? |
Closing as it is now part of #290. |
This PR is in anticipation of nodejs/node#10558 (do not land this before the node core PR).
Also, this should land before #253 so that the replacements are done in the correct order.
/cc @mcollina