-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use proper datetime to fix server-side/client-siode mismatch #5479
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed in the preview that the behavior reported within #5478 is resolved
@bmuenzenmeyer Could you maybe open an issue regarding we providing a generic Component for the The component should have two props: The component should return a |
@bmuenzenmeyer on the above, if you feel like you can introduce a component quickly enough, no need to open an issue if you feel like doing it. Shouldn't take enough time. And this would allow the formatted times to actually be shown in the language/date format of the currently applied locale. |
Description
This PR fixes two issues on the Node.js Website related to rendering.
time
HTML elements by using JavaScript's built-intoLocaleString
function. We've forced aUTC
timezone and useen-GB
locale information.theme.tsx
memoization asserts both props as being the same as the comparison only used the MDX content as a comparison, excluding other props such as frontmatter. This should fix Next.js, not "moving" to another page. (The issue is that a re-rendering would not occur).strftime
package and utilities that are not used anymore.Fixes #5478