Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page content does not update when navigating from "News" to "Downloads" page #5478

Closed
mikeesto opened this issue Jul 7, 2023 · 3 comments · Fixed by #5479
Closed

Page content does not update when navigating from "News" to "Downloads" page #5478

mikeesto opened this issue Jul 7, 2023 · 3 comments · Fixed by #5479
Labels

Comments

@mikeesto
Copy link
Member

mikeesto commented Jul 7, 2023

URL:

https://nodejs.org/en/blog

Browser Name:

Chrome

Browser Version:

114.0.5735.198

Operating System:

MacOS

How to reproduce the issue:

  1. Open https://nodejs.org/en/blog
  2. Click on 'Downloads' in the top nav bar
  3. The URL updates but the page content does not - I would expect to see the content for Downloads
@mikeesto mikeesto added the bug label Jul 7, 2023
@bmuenzenmeyer
Copy link
Collaborator

it looks like you can reproduce the behavior in the opposite direction too

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Jul 7, 2023

When I debug issues, I usually stream of conscious them, so this might be way off base, but I hope it jumps starts some thoughts.

initial triage, reading up on the next console log A soft navigation has been detected: https://nodejs.org/en/blog led me to vercel/next.js#42991

Also not certain how relevant this is because we only use the app directory for feeds from what I can tell

Here's the soft-navigation docs: https://nextjs.org/docs/app/building-your-application/routing/linking-and-navigating#conditions-for-soft-navigation

I wonder if it was broken prior to this hotfix yesterday #5474 introduced to alleviate pressure on the site.

@ovflowd
Copy link
Member

ovflowd commented Jul 7, 2023

This seems to be a regression caused by #5464 (which was not properly tested or rather seemed working fine) and it's fixed by #5479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants