Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): dir name #5354

Merged
merged 109 commits into from
May 11, 2023
Merged

fix(test): dir name #5354

merged 109 commits into from
May 11, 2023

Conversation

AugustinMauroy
Copy link
Member

use __tests__ not __test__

AugustinMauroy and others added 30 commits April 15, 2023 10:17
@AugustinMauroy @ovflowd
feat(unit-test): introduce unit test on website redesign branch (#5178
bd8a46e 
feat(unit-test): introduce unit test
@ovflowd
chore(redesign): added new folders for new layouts and new pages
80039d3
@ovflowd
chore(minor): just a tiny design nitpick
cdbc4b4
@araujogui @ovflowd
chore: set up storybook (#5191) (#5214)
df79868
@AugustinMauroy @ovflowd
feat(ignore): add storyBook (#5229)
ecbec61
@araujogui @manishprivet @ovflowd
chore: set up testing-library jest extend (#5231)
a2a4bd8 
Co-authored-by: Manish Kumar ⛄ <[email protected]>
@ovflowd
chore(dependencies): updated dependencies
67999b6
@araujogui @SEWeiTung @ovflowd
feat: create section title component (#5237)
48d6c91 
Co-authored-by: Wai.Tung <[email protected]>
@manishprivet @shanpriyan
@mikeesto @ovflowd
📎 chore(migration): migrate banner component (#5233)
6ce6923 
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
@HinataKah0 @ovflowd
feat: migrate AnimatedPlaceholder component (#5238
f9d9765 
Migrate AnimatedPlaceholder component from nodejs.dev
and create a new Story.
@araujogui @ovflowd
feat: create article alert component (#5243)
9311785
@ovflowd
chore(dependencies): updated dependencies
06ce22b
@ovflowd
fix: formatted file
386a458
@ovflowd
chore: updated deps
0240b9b
@araujogui
feat: migrate blockquote component (#5259)
ffa9a3e
@ovflowd
feat(stylelint,storybook): fixed styleling misconfig and fixed storyb…
390c2da 
…ooks (#5281)
@Olaleye-Blessing
feat: create article data tag component (#5280)
e121b83
@shanpriyan @mikeesto
feat: migrate AuthorList component and add story 🎉 (#5277)
d7a154d 
Co-authored-by: Michael Esteban <[email protected]>
@ovflowd
chore: lock nextjs to 13.2.0 (#5301
620f58e 
chore: next lock to versin 13.2.0
@ktssr @ovflowd
@shanpriyan @mikeesto
chore(migration): migrate language selector component (#5266)
79b5134 
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
@shanpriyan @ovflowd
feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236
bb46dfe 
)

Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
@ovflowd @shanpriyan @manishprivet
chore: updated contributing guidelines, eslint rules and storybook te…
bfcabb9 
…mplates (#5294)

Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Manish Kumar ⛄ <[email protected]>
@ovflowd
chore: contributing quick fix of example
f6dc39f 
Signed-off-by: Claudio Wunder <[email protected]>
@ovflowd
chore: story guide and react spreading
2eba819 
Signed-off-by: Claudio Wunder <[email protected]>
@ovflowd
chore: remove base styles from old styling
86b60f3
@ovflowd
chore: fix storybook styles, imports, typescript config and dependenc…
1f4530e 
…ies (#5319

* chore: optimises tsconfig

* chiore: add missing dependencies

* chore: type storybook constants

* chore: styles moved styles to somewhere else

* chore: add global json type definition

* chore: i18n aria-label instead of sr-only

* chore: added open sans font family and space between imports

* chore: moved styles and fixed styles and updated banner stories

* fix: stylelint rules

* chore: updated tsconfig

* chore: fix tests

* fix: darkmodetoggle test

* chore: stories use index.stories.tsx
@ovflowd
chore: adopt turborepo (#5316
b8c76cd 
* chore: revert pnpm use plain npm

* fix: package.json

* chore: remove warnings and add node_env

* chore: cross-env

* fix: fix turbo pipelines

* chore: only cache certain files

* chore: turbo shouldn't care about coverage outputs

* chore: proper inputs and outputs for pipelines

* chore: do not store some outputs and updated inputs for lint

* chore: added prettier configs

* chore: remove console.info

* chore: updated inputs of all other entries
@Harkunwar
fix(package.json) Lint command is missing slashes (#5321
5891807 
fix(package.json) lint:fix missing slashes
@vasanth9 @shanpriyan
moved DataTag to components/Api (#5317)
ca8b5ab 
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Shanmughapriyan S <[email protected]>
@ovflowd
hot-fix: dependency updates and fix dev runtime
c2aeeaa
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 4, 2023 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 4, 2023 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 6, 2023 10:18 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 6, 2023 10:19 Inactive
@Harkunwar
Copy link
Contributor

I beleive this test is not needed as it's already captured by storybook.

https://github.com/nodejs/nodejs.org/tree/major/website-redesign/components/Home/NodeFeatures

Harkunwar
Harkunwar previously requested changes May 6, 2023
View reviewed changes
Copy link
Contributor

@Harkunwar Harkunwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please delete the components/Home/NodeFeatures/__tests__ directory since it's not needed anymore.

@AugustinMauroy
Copy link
Member Author

Hey @Harkunwar I don't saw what do you mean.
Can you give more explaining

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 7, 2023 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 7, 2023 08:21 Inactive
@ovflowd ovflowd dismissed Harkunwar’s stale review May 7, 2023 09:41

changes applied

@ovflowd ovflowd enabled auto-merge (squash) May 7, 2023 09:42
@Harkunwar
Copy link
Contributor

Hey @Harkunwar I don't saw what do you mean.
Can you give more explaining

Since we're using Storybook to automatically do Snapshot testing, we don't need to write unit tests in Jest to do them anymore, which is why I said you could delete the test as well as the snapshot. Any component written in storybook will automatically have a snapshot generated instead of a manual test.

@Harkunwar
Copy link
Contributor

@ovflowd Are we waiting for anything, should we merge this?

@AugustinMauroy
Copy link
Member Author

@Harkunwar I thinks you can merge. Claudio are too busy this week.

@vercel vercel bot temporarily deployed to Preview – nodejs-org May 11, 2023 08:18 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 11, 2023 08:19 Inactive
@Harkunwar Harkunwar disabled auto-merge May 11, 2023 19:17
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 11, 2023 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 11, 2023 19:22 Inactive
@Harkunwar Harkunwar merged commit 49efa04 into nodejs:major/website-redesign May 11, 2023
Ve33y pushed a commit to Ve33y/nodejs.org that referenced this pull request May 12, 2023
@AugustinMauroy @Ve33y
fix(test): dir name (nodejs#5354)
c3e9ab4 
Signed-off-by: Vessy Shestorkina <[email protected]>
ovflowd added a commit that referenced this pull request May 17, 2023
@ovflowd @Harkunwar
@manishprivet @SEWeiTung @shanpriyan @mikeesto @aymen94 @AugustinMauroy @araujogui @HinataKah0 @Olaleye-Blessing @ktssr @vasanth9 @FHachez @JatinSharma32 @Ve33y @mertcanaltin
chore: updates main with latest major/website-redesign (#5382)
2065bf7 
* test(snapshot): Migrate snapshot tests to storybook (#5340)

Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Aymen Naghmouchi <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: Guilherme Araújo <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: HinataKah0 <[email protected]>
Co-authored-by: Olaleye Blessing <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: vasanthkumar <[email protected]>
Co-authored-by: Floran Hachez <[email protected]>
Co-authored-by: Jatin <[email protected]>
fixed styleling misconfig and fixed storybooks (#5281)
fix storybook styles, imports, typescript config and dependencies (#5319
fix(package.json) Lint command is missing slashes (#5321
fix storybook local development mode (#5335)
fix(i18n): translation key (#5347)

* chore: no-unused-vars ignores pattern starting with _ (#5363)

* Contributing Guidelines Update - Add clarity to step 4 based on clone method (#5369)

Add clarity to step 4 based on clone method

Signed-off-by: Vessy Shestorkina <[email protected]>

* fix(test): dir name (#5354)

* feat(stability): migrate component (#5339)

* Migrate JsonLink component (#5370)

* Migrate JsonLink component

Signed-off-by: Vessy Shestorkina <[email protected]>

* Add storybook snap and robot icon

Signed-off-by: Vessy Shestorkina <[email protected]>

* Remove IconContext provider

Signed-off-by: Vessy Shestorkina <[email protected]>

---------

Signed-off-by: Vessy Shestorkina <[email protected]>
Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376)

* refactor(useDownloadLink): Move useDetectOs to useDownloadLink

* refactor(useDownloadLink): rename file

* refactor(useDownloadLink): rename file

* Apply suggestions from code review

Signed-off-by: Claudio Wunder <[email protected]>

* refactor(useDownloadLink): undo deleted file

---------

Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* feat: Add MUI Config and Theme Provider (#5368)

* feat: Add MUI Config and Theme Provider

* added createTheme

* refactor themeConfig

* feat(theme): Fix linting and package-lock

* feat(theme): Add emotion styled and emtion react

---------

Co-authored-by: Harkunwar Kochar <[email protected]>

* refactor(delete): duplicate test file (#5377)

refactor(test): Delete duplicate test file

Co-authored-by: Claudio Wunder <[email protected]>

* feat(useClickOutside): introduce (#5359)

* feat(useClickOutside): introduce

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* feat(useClickOutside): fix and twix

* feat(dropdown): remove useless ref

* feat(useClickOutside): update unit test

* feat(UseClickOutside): update type

* fix: usage of type

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* update listener

* Update components/Common/LanguageSelector/index.tsx

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix: languageSelector

* update with feedback

* better unit test

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* feat(useClickOutside): update with feedback

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix: if click on modal

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update hooks/useClickOutside.ts

Signed-off-by: Harkunwar Kochar <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update useClickOutside.ts

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update useClickOutside.ts

* Apply suggestions from code review

Signed-off-by: Claudio Wunder <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix: build

---------

Signed-off-by: Augustin Mauroy <[email protected]>
Signed-off-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Harkunwar Kochar <[email protected]>

---------

Signed-off-by: Vessy Shestorkina <[email protected]>
Signed-off-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>
Signed-off-by: Harkunwar Kochar <[email protected]>
Co-authored-by: Harkunwar Kochar <[email protected]>
Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Aymen Naghmouchi <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: Guilherme Araújo <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: HinataKah0 <[email protected]>
Co-authored-by: Olaleye Blessing <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: vasanthkumar <[email protected]>
Co-authored-by: Floran Hachez <[email protected]>
Co-authored-by: Jatin <[email protected]>
Co-authored-by: Vessy <[email protected]>
Co-authored-by: Mert Can Altın <[email protected]>
ovflowd pushed a commit that referenced this pull request May 24, 2023
@AugustinMauroy @ovflowd
fix(test): dir name (#5354)
c6e4f6a
ovflowd pushed a commit that referenced this pull request May 24, 2023
@AugustinMauroy @ovflowd
fix(test): dir name (#5354)
b94cb5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanpriyan shanpriyan shanpriyan approved these changes

@mikeesto mikeesto mikeesto approved these changes

@aymen94 aymen94 aymen94 approved these changes

@ovflowd ovflowd ovflowd approved these changes

@Harkunwar Harkunwar Harkunwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.