Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stability): migrate component #5339

Merged
merged 62 commits into from
May 14, 2023
Merged

feat(stability): migrate component #5339

merged 62 commits into from
May 14, 2023

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Apr 28, 2023

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2023 8:01am
nodejs-org-stories ✅ Ready (Inspect) Visit Preview May 14, 2023 8:01am

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 28, 2023 20:45 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 28, 2023 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 29, 2023 09:03 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 29, 2023 09:04 Inactive
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but overall, LGTM! (And thanks for the contribution!)

@vercel vercel bot temporarily deployed to Preview – nodejs-org April 30, 2023 10:49 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 30, 2023 10:50 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 30, 2023 16:21 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 30, 2023 16:22 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 30, 2023 21:54 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 30, 2023 21:56 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 1, 2023 03:36 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 1, 2023 03:37 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 3, 2023 08:55 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 3, 2023 08:57 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 3, 2023 11:33 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 3, 2023 11:34 Inactive
@ovflowd ovflowd force-pushed the major/website-redesign branch from 7ddfa8d to f2a3ac4 Compare May 3, 2023 23:05
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 4, 2023 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 4, 2023 13:20 Inactive
@ovflowd ovflowd deleted the branch nodejs:major/website-redesign May 4, 2023 13:23
@ovflowd ovflowd closed this May 4, 2023
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 4, 2023 13:24 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 4, 2023 13:25 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 5, 2023 08:01 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 5, 2023 08:02 Inactive
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! A little comment about the unit tests s

components/Api/Stability/__test__/index.test.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 11, 2023 08:33 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 11, 2023 08:37 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 11, 2023 08:39 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 11, 2023 08:44 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 12, 2023 18:47 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 12, 2023 18:48 Inactive
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a tiny comment

components/Api/Stability/index.module.scss Show resolved Hide resolved
Co-authored-by: Jithil P Ponnan <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 13, 2023 13:35 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 13, 2023 13:35 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 13, 2023 15:47 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 13, 2023 15:49 Inactive
Co-authored-by: Jithil P Ponnan <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 14, 2023 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 14, 2023 08:01 Inactive
Copy link
Contributor

@HinataKah0 HinataKah0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ovflowd ovflowd merged commit 9221386 into nodejs:major/website-redesign May 14, 2023
ovflowd added a commit that referenced this pull request May 17, 2023
* test(snapshot): Migrate snapshot tests to storybook (#5340)

Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Aymen Naghmouchi <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: Guilherme Araújo <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: HinataKah0 <[email protected]>
Co-authored-by: Olaleye Blessing <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: vasanthkumar <[email protected]>
Co-authored-by: Floran Hachez <[email protected]>
Co-authored-by: Jatin <[email protected]>
fixed styleling misconfig and fixed storybooks (#5281)
fix storybook styles, imports, typescript config and dependencies (#5319
fix(package.json) Lint command is missing slashes (#5321
fix storybook local development mode (#5335)
fix(i18n): translation key (#5347)

* chore: no-unused-vars ignores pattern starting with _ (#5363)

* Contributing Guidelines Update - Add clarity to step 4 based on clone method (#5369)

Add clarity to step 4 based on clone method

Signed-off-by: Vessy Shestorkina <[email protected]>

* fix(test): dir name (#5354)

* feat(stability): migrate component (#5339)

* Migrate JsonLink component (#5370)

* Migrate JsonLink component

Signed-off-by: Vessy Shestorkina <[email protected]>

* Add storybook snap and robot icon

Signed-off-by: Vessy Shestorkina <[email protected]>

* Remove IconContext provider

Signed-off-by: Vessy Shestorkina <[email protected]>

---------

Signed-off-by: Vessy Shestorkina <[email protected]>
Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376)

* refactor(useDownloadLink): Move useDetectOs to useDownloadLink

* refactor(useDownloadLink): rename file

* refactor(useDownloadLink): rename file

* Apply suggestions from code review

Signed-off-by: Claudio Wunder <[email protected]>

* refactor(useDownloadLink): undo deleted file

---------

Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>

* feat: Add MUI Config and Theme Provider (#5368)

* feat: Add MUI Config and Theme Provider

* added createTheme

* refactor themeConfig

* feat(theme): Fix linting and package-lock

* feat(theme): Add emotion styled and emtion react

---------

Co-authored-by: Harkunwar Kochar <[email protected]>

* refactor(delete): duplicate test file (#5377)

refactor(test): Delete duplicate test file

Co-authored-by: Claudio Wunder <[email protected]>

* feat(useClickOutside): introduce (#5359)

* feat(useClickOutside): introduce

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* feat(useClickOutside): fix and twix

* feat(dropdown): remove useless ref

* feat(useClickOutside): update unit test

* feat(UseClickOutside): update type

* fix: usage of type

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* update listener

* Update components/Common/LanguageSelector/index.tsx

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix: languageSelector

* update with feedback

* better unit test

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* feat(useClickOutside): update with feedback

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix: if click on modal

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update hooks/useClickOutside.ts

Signed-off-by: Harkunwar Kochar <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update useClickOutside.ts

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update useClickOutside.ts

* Apply suggestions from code review

Signed-off-by: Claudio Wunder <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix: build

---------

Signed-off-by: Augustin Mauroy <[email protected]>
Signed-off-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Harkunwar Kochar <[email protected]>

---------

Signed-off-by: Vessy Shestorkina <[email protected]>
Signed-off-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>
Signed-off-by: Harkunwar Kochar <[email protected]>
Co-authored-by: Harkunwar Kochar <[email protected]>
Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Aymen Naghmouchi <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: Guilherme Araújo <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: HinataKah0 <[email protected]>
Co-authored-by: Olaleye Blessing <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: vasanthkumar <[email protected]>
Co-authored-by: Floran Hachez <[email protected]>
Co-authored-by: Jatin <[email protected]>
Co-authored-by: Vessy <[email protected]>
Co-authored-by: Mert Can Altın <[email protected]>
ovflowd pushed a commit that referenced this pull request May 24, 2023
ovflowd pushed a commit that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.