-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: update outdated comment #8968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you @Tanuja-Sawant!
This change is small enough that it should not need to wait the full 48 hours to land.
One nit: @Tanuja-Sawant, can you please update the commit log message to follow the guidelines described in the contributor's guide? |
@jasnell is this commit log fine? |
@Tanuja-Sawant ... my apologies for not being clear. I meant the actual commit log message here: e5ed61f. You can update it using |
@@ -50,8 +50,8 @@ exports.fork = function(modulePath /*, args, options*/) { | |||
args = execArgv.concat([modulePath], args); | |||
|
|||
if (!Array.isArray(options.stdio)) { | |||
// Leave stdin open for the IPC channel. stdout and stderr should be the | |||
// same as the parent's if silent isn't set. | |||
// Use a separate fd=4 for IPC channel. Inherit stdin, stdout and stderr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the correct fd index for the IPC channel here should be fd=3, not fd=4.
Quoting the docs:
The fds 0, 1, and 2 correspond to stdin, stdout, and stderr, respectively.
@@ -50,8 +50,8 @@ exports.fork = function(modulePath /*, args, options*/) { | |||
args = execArgv.concat([modulePath], args); | |||
|
|||
if (!Array.isArray(options.stdio)) { | |||
// Leave stdin open for the IPC channel. stdout and stderr should be the | |||
// same as the parent's if silent isn't set. | |||
// Use a separate fd=4 for IPC channel. Inherit stdin, stdout and stderr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave the "the" before "IPC channel". Also, please add a comma after "stdout."
Hi! |
Checklist
Affected core subsystem(s)
just comments
Description of change
Updated an outdated comment in child_process.js to describe the code better.