Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: outdated comment #8927

Closed
mscdex opened this issue Oct 4, 2016 · 4 comments
Closed

child_process: outdated comment #8927

mscdex opened this issue Oct 4, 2016 · 4 comments
Labels
child_process Issues and PRs related to the child_process subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Oct 4, 2016

  • Version: all
  • Platform: n/a
  • Subsystem: child_process

There is an outdated comment in lib/child_process.js that needs to be updated to better reflect what the code beneath it has been doing for some time now. Instead of commandeering stdin for IPC usage, a separate fd is actually used for IPC.

@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. good first issue Issues that are suitable for first-time contributors. labels Oct 4, 2016
@tanujasawant
Copy link
Contributor

tanujasawant commented Oct 7, 2016

I'm Tanuja Sawant and would like to work on this issue as part of one of my initial contributions to Node.js for the Outreachy Internship. Would you kindly assign this issue to me or should I go ahead and make a pull request?
Thanks so much!

@tanujasawant
Copy link
Contributor

tanujasawant commented Oct 7, 2016

Hi again!
Please correct me if I'm wrong, the comment

// Leave stdin open for the IPC channel. stdout and stderr should be the
// same as the parent's if silent isn't set.

can be replaced by

// Use a separate fd=4 for IPC channel. Inherit stdin, stdout and stderr 
// from the parent if silent isn't set.

@bnoordhuis
Copy link
Member

@Tanuja-Sawant Can you open a pull request? Collaborators will review it and suggest changes if necessary.

@mscdex mscdex removed the good first issue Issues that are suitable for first-time contributors. label Oct 7, 2016
@tanujasawant
Copy link
Contributor

tanujasawant commented Oct 7, 2016

pulled request in #8988

@mscdex mscdex closed this as completed Nov 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Development

No branches or pull requests

3 participants