repl: Mitigate vm #548 function redefinition issue #7794

princejwesley · 2016-07-19T18:12:14Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

repl

Description of change

Back port of #7624

node 🙈 ₹ git:(upstream ⚡ repl-tmp-548) ./node
> function name() { return "node"; };
undefined
> name()
'node'
> function name() { return "nodejs"; };
undefined
> name()
'nodejs'
>

@piccoloaiutante

As titled. Tested by @piccoloaiutante. PR-URL: nodejs#4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Frederic Hemberger <[email protected]>

Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. PR-URL: nodejs#7647 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>

Hopefully clarify the behaviour of `buffer.indexOf()` and `buffer.includes()` for numbers in that they will be truncated to uint8s. Add tests for that behaviour. Fixes: nodejs#7591 PR-URL: nodejs#7611 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>

compliment -> complement PR-URL: nodejs#7568 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

All quotes in .eslintrc were unnecessary and inconsistently placed across the file. Additionally, format the globals to be consistent with the style of whitespace and sorted them alphabetically. PR-URL: nodejs#7691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

PR-URL: nodejs#2569 Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Wexpo Lyu <[email protected]> Reviewed-By: Yiyu He <[email protected]> Reviewed-By: Yorkie Liu <[email protected]>

Current implementation tracks connected/disconnected status separately which potentially introduces race condition. This change introduces notion of session IDs and also posts connect/disconnect events into the same queue as the messages. This way Node knows what session given response belongs to and can discard messages if the frontend for that session had disconnected. This also fixes an issue when frontend was unable to attach to V8 instance that was running infinite loop. PR-URL: nodejs#7271 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>

A few of the child process tests can be simplified by computing the OS specific root directory in common and then accessing that value. PR-URL: nodejs#7685 Reviewed-By: Roman Reiss <[email protected]>

The name 'event' for the argument of the listener in fs.watch was confusing considering FSWatcher also had events. This changes the name of the argument to eventType. Fixes: nodejs#7504 PR-URL: nodejs#7506 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

A number of test files use IIFEs to separate distinct tests from each other in the same file. The project has been moving toward using block scopes and let/const in favor of IIFEs. This commit moves IIFE tests to block scopes. Some additional cleanup such as use of strictEqual() and common.mustCall() is also included. PR-URL: nodejs#7694 Reviewed-By: Santiago Gimeno <[email protected]>

Provide additional information about values that indicate test failed. PR-URL: nodejs#7693 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>

"doc/api/fs.md" file had some conflict markers like "<<<<<<< HEAD" that are visible at the bottom of https://nodejs.org/api/fs.html PR-URL: nodejs#7590 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Fixes regression where creating a new Buffer from an empty ArrayBuffer would fail. Ref: nodejs@85ab4a5 PR-URL: nodejs#7176 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ron Korving <[email protected]>

Original commit message: Quit creating array literal boilerplates from Crankshaft. It's such a corner case. BUG= Review URL: https://codereview.chromium.org/1865013002 Cr-Commit-Position: refs/heads/master@{nodejs#35346} Fixes: nodejs#7454 PR-URL: nodejs#7633 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

This commit removes the use of self and bind() from the cluster module in favor of arrow functions. PR-URL: nodejs#7710 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

Fix small typo in Buffering section of stream doc. PR-URL: nodejs#7738 Reviewed-By: Brian White <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

State in the documentation that `uncaughtException` is not a reliable way to restart a crashed application, and clarify that an application may crash in ways that do not trigger this event. Use a documented synchronous function in example code. Fixes: nodejs#6223 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs#6378

Whenever a timer is scheduled within another timer, there are a few known issues that we are fixing: * Whenever the timer being scheduled has the same timeout value as the outer timer, the newly created timer can fire on the same tick of the event loop instead of during the next tick of the event loop * Whenever a timer is added in another timer's callback, its underlying timer handle will be started with a timeout that is actually incorrect This commit consists of nodejs/node-v0.x-archive#17203 and nodejs/node-v0.x-archive#25763. Fixes: nodejs/node-v0.x-archive#9333 Fixes: nodejs/node-v0.x-archive#15447 Fixes: nodejs/node-v0.x-archive#25607 Fixes: nodejs#5426 PR-URL: nodejs#3063

Adds missing semicolons, removes extra white space, and properly indents various code snippets in the documentation. Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> PR-URL: nodejs#7745

Many tests use assert.fail(null, null, msg) where it would be simpler to use common.fail(msg). This is largely because common.fail() is fairly new. This commit makes the replacement when applicable. PR-URL: nodejs#7735 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it if `target_arch=="x64"`. See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx PR-URL: nodejs#7759 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

Inspect boxed symbol objects in the same way other boxed primitives are inspected. Fixes: nodejs#7639 PR-URL: nodejs#7641 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

PR-URL: nodejs#7602 Reviewed-By: Anna Henningsen <[email protected]>

Using identical timeout values appears to have eliminated the flakiness in the test. Fixes: nodejs#7643 PR-URL: nodejs#7717 Reviewed-By: Fedor Indutny <[email protected]>

Ref: nodejs#6578 PR-URL: nodejs#7287 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>

Fix handle leaks in Buffer::New() and Buffer::Copy() by creating the handle scope before looking up the env with Environment::GetCurrent(). Environment::GetCurrent() calls v8::Isolate::GetCurrentContext(), which creates a handle in the current scope, i.e., the scope created by the caller of Buffer::New() or Buffer::Copy(). PR-URL: nodejs#7711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]>

Create a handle scope before performing a check that creates a handle, otherwise the handle is leaked into the handle scope of the caller. PR-URL: nodejs#7711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]>

API function callbacks run inside an implicit HandleScope. We don't need to explicitly create one and in fact introduce some unnecessary overhead when we do. PR-URL: nodejs#7711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]>

Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`. PR-URL: nodejs#7777 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

The test case fails in AIX due to the mixed-use of unspecified and loopback addresses. This is not a problem in most platforms but fails in AIX. (In Windows too, but does not manifest as the test is omitted in Windows for a different reason). There exists no documented evidence which supports the mixed use of unspecified and loopback addresses. While AIX strictly follows the IPV6 specification with respect to unspecified address ('::') and loopback address ('::1'), the test case latches on to the behavior exhibited by other platforms, and hence it fails in AIX. The proposed fix is to make it work in all platforms including AIX by using the loopback address for the client to connect, as that is the address at which the server listens. Fixes: nodejs#7563 PR-URL: nodejs#7702 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Update some outdated material. Provide some minor fixes. Wrap to 80 characters. PR-URL: nodejs#7719 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trevor Norris <[email protected]>

Remove wtf files as v8_inspector no longer needs them. Ref: nodejs#7123 PR-URL: nodejs#7751 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

```js node 🙈 ₹ git:(upstream ⚡ repl-tmp-548) ./node > function name() { return "node"; }; undefined > name() 'node' > function name() { return "nodejs"; }; undefined > name() 'nodejs' > ```

evanlucas · 2016-07-19T23:39:37Z

Thanks @princejwesley! CI: https://ci.nodejs.org/job/node-test-pull-request/3343/

Rubberstamp LGTM if CI is happy

evanlucas · 2016-07-20T11:48:20Z

Hm, trying CI again (https://ci.nodejs.org/job/node-test-pull-request/3353/). I think there are some plinux issues on the ci right now. And don't worry about the conflicts showing here, I should be able to just cherry-pick that last commit now. I had to back some stuff out of v6.x

```js node 🙈 ₹ git:(upstream ⚡ repl-tmp-548) ./node > function name() { return "node"; }; undefined > name() 'node' > function name() { return "nodejs"; }; undefined > name() 'nodejs' > ``` PR-URL: #7794 Reviewed-By: Evan Lucas <[email protected]>

evanlucas · 2016-07-21T11:43:29Z

Landed in v6.x in 72fc4eb. Thanks!

Notable changes: * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602 * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176 * **deps**: Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531 * **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794 * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641 PR-URL: #7782

Notable changes: * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602 * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176 * **deps**: * Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531 * Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638 * **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794 * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641 PR-URL: #7782

### Notable changes * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) [#7602](nodejs/node#7602) * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) [#7176](nodejs/node#7176) * **deps**: * Upgrade to V8 5.0.71.xx. (Ben Noordhuis) [#7531](nodejs/node#7531) * Backport V8 instanceof bugfix (Franziska Hinkelmann) [#7638](nodejs/node#7638) * **repl**: Fix issue with function redeclaration. (Prince J Wesley) [#7794](nodejs/node#7794) * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) [#7641](nodejs/node#7641)

mcollina and others added 30 commits July 15, 2016 08:18

win,msi: Added Italian translation

f25c7ce

As titled. Tested by @piccoloaiutante. PR-URL: nodejs#4647 Refs: wixtoolset/wix3#366 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Frederic Hemberger <[email protected]>

doc: fix typo in the CHANGELOG_V6

45a8fce

compliment -> complement PR-URL: nodejs#7568 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

win,msi: add zh-CN translations for the installer

e1e477e

PR-URL: nodejs#2569 Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Wexpo Lyu <[email protected]> Reviewed-By: Yiyu He <[email protected]> Reviewed-By: Yorkie Liu <[email protected]>

test: add common.rootDir

ccd4983

A few of the child process tests can be simplified by computing the OS specific root directory in common and then accessing that value. PR-URL: nodejs#7685 Reviewed-By: Roman Reiss <[email protected]>

test: improve error message in test-tick-processor

d224b47

Provide additional information about values that indicate test failed. PR-URL: nodejs#7693 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>

doc: fix inconsistencies in code style

669af6e

Adds missing semicolons, removes extra white space, and properly indents various code snippets in the documentation. Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> PR-URL: nodejs#7745

buffer: optimize hex_decode

ba6ab7c

PR-URL: nodejs#7602 Reviewed-By: Anna Henningsen <[email protected]>

test: fix flaky test-http-server-consumed-timeout

aa045cd

Using identical timeout values appears to have eliminated the flakiness in the test. Fixes: nodejs#7643 PR-URL: nodejs#7717 Reviewed-By: Fedor Indutny <[email protected]>

doc: add added: information for stream

f7d3af6

Ref: nodejs#6578 PR-URL: nodejs#7287 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>

doc: correct sample output of buf.compare

62a3ff2

Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`. PR-URL: nodejs#7777 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

gireeshpunathil and others added 4 commits July 19, 2016 05:45

deps: v8_inspector no longer depends on wtf

f3182f6

Remove wtf files as v8_inspector no longer needs them. Ref: nodejs#7123 PR-URL: nodejs#7751 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>

repl: Mitigate vm nodejs#548 function redefinition issue

dedf6c4

```js node 🙈 ₹ git:(upstream ⚡ repl-tmp-548) ./node > function name() { return "node"; }; undefined > name() 'node' > function name() { return "nodejs"; }; undefined > name() 'nodejs' > ```

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Jul 19, 2016

mscdex added the v6.x label Jul 19, 2016

evanlucas force-pushed the v6.x branch from f3182f6 to cf8a488 Compare July 20, 2016 11:37

evanlucas closed this Jul 21, 2016

evanlucas mentioned this pull request Jul 21, 2016

v6.3.1 Release Proposal #7782

Merged

cjean-fr mentioned this pull request Jul 24, 2016

Upgrade node to 6.3.1 ScoopInstaller/Scoop#966

Merged

MylesBorins added the dont-land-on-v4.x label Oct 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repl: Mitigate vm #548 function redefinition issue #7794

repl: Mitigate vm #548 function redefinition issue #7794

princejwesley commented Jul 19, 2016

evanlucas commented Jul 19, 2016

evanlucas commented Jul 20, 2016 •

edited

Loading

evanlucas commented Jul 21, 2016

repl: Mitigate vm #548 function redefinition issue #7794

repl: Mitigate vm #548 function redefinition issue #7794

Conversation

princejwesley commented Jul 19, 2016

Checklist

Affected core subsystem(s)

Description of change

evanlucas commented Jul 19, 2016

evanlucas commented Jul 20, 2016 • edited Loading

evanlucas commented Jul 21, 2016

evanlucas commented Jul 20, 2016 •

edited

Loading