repl: wrong repl stack trace column number in strict mode #5416

princejwesley · 2016-02-24T19:37:11Z

Pull Request check-list

Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?
Is the commit message formatted according to CONTRIBUTING.md?
If this change fixes a bug (or a performance problem), is a regression
test (or a benchmark) included?
Is a documentation update included (if this change modifies
existing APIs, or introduces new ones)?

Affected core subsystem(s)

repl

Description of change

This PR addresses the below problem.

Problem

On REPL strict mode, 'use strict'; void 0; is added as prefix in order to prevent
"use strict" as the result value for let/const statements. It causes wrong column number in
stack trace.

Code for REPL with strict mode

Desktop 🙈 ₹ cat strict-repl.js
'use strict';
let net = require('net');
let repl = require('repl')

repl.start({
  replMode: repl.REPL_MODE_STRICT
});

net.createServer(function(socket) {
  repl.start("node via TCP socket> ", socket);
}).listen(5001);

Output

Desktop 🙈 ₹ node strict-repl.js
> x = 1
ReferenceError: x is not defined
    at repl:1:25 // <- column number should be 3
    at REPLServer.defaultEval (repl.js:264:27)
    at bound (domain.js:287:14)
    at REPLServer.runBound [as eval] (domain.js:300:12)
    at REPLServer.<anonymous> (repl.js:427:12)
    at emitOne (events.js:90:13)
    at REPLServer.emit (events.js:182:7)
    at REPLServer.Interface._onLine (readline.js:211:10)
    at REPLServer.Interface._line (readline.js:550:8)
    at REPLServer.Interface._ttyWrite (readline.js:827:14)
>

Behavior

Length of 'use strict'; void 0; (22 chars) is added up to column number. ❌

Output (after fix)

node 🙈 ₹ git:(upstream ⚡ repl-linenumber) ./node ~/Desktop/strict-repl.js
> x = 1
ReferenceError: x is not defined
    at repl:1:3
    at REPLServer.defaultEval (repl.js:264:27)
    at bound (domain.js:281:14)
    at REPLServer.runBound [as eval] (domain.js:294:12)
    at REPLServer.<anonymous> (repl.js:431:12)
    at emitOne (events.js:91:13)
    at REPLServer.emit (events.js:183:7)
    at REPLServer.Interface._onLine (readline.js:216:10)
    at REPLServer.Interface._line (readline.js:555:8)
    at REPLServer.Interface._ttyWrite (readline.js:832:14)
>

Fishrock123 · 2016-02-24T22:11:46Z

lib/repl.js

@@ -289,6 +289,10 @@ function REPLServer(prompt,
    debug('domain error');
    const top = replMap.get(self);
    internalUtil.decorateErrorStack(e);
+    if (e.stack && self.replMode === exports.REPL_MODE_STRICT) {
+      e.stack = e.stack.replace(/(\s+at\s+repl:)(\d+)/,
+                                (_, pre, line) => pre + (parseInt(line) - 1));


I don't think we need the parseInt() here, "3" - 1 will be faster, and the regex is going to guarantee an integer anyway.

Edit: also the parenthesis around the 2nd math seem to be extraneous.

@Fishrock123 parseInt is removed. parenthesis around subtraction is required because arithmetic operators are left associative and pre is a string.

Fishrock123 · 2016-02-24T22:13:48Z

LGTM once CI is back online so that we can run the tests

cjihrig · 2016-02-24T22:43:44Z

LGTM

On strict mode, "'use strict'; void 0; " is added as prefix in order to prevent "use strict" as the result value for let/const statements. It causes wrong column number in stack trace.

silverwind · 2016-02-26T01:56:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/1756/

princejwesley · 2016-02-29T09:39:23Z

@silverwind Green build?

silverwind · 2016-02-29T09:43:36Z

Yes!

silverwind · 2016-02-29T09:48:14Z

Thanks! Landed in 40d57b7.

On strict mode, "'use strict'; void 0; " is added as prefix in order to prevent "use strict" as the result value for let/const statements. It causes wrong column number in stack trace. PR-URL: #5416 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

jasnell · 2016-03-02T16:30:07Z

Marked for LTS watch... still need to verify that this bug is relevant for v4, however. /cc @nodejs/lts

On strict mode, "'use strict'; void 0; " is added as prefix in order to prevent "use strict" as the result value for let/const statements. It causes wrong column number in stack trace. PR-URL: #5416 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

MylesBorins · 2016-03-17T18:43:08Z

one more ping to @nodejs/lts

MylesBorins · 2016-03-30T18:20:13Z

I've gone through and manually followed the reproduction steps and saw this error on v4.

After backporting the change things are fixed.

As such I'm moving this to staging.

On strict mode, "'use strict'; void 0; " is added as prefix in order to prevent "use strict" as the result value for let/const statements. It causes wrong column number in stack trace. PR-URL: #5416 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

Notable Changes * https: - Under certain conditions ssl sockets may have been causing a memory leak when keepalive is enabled. This is no longer the case. - (Alexander Penev) #5713 * lib: - The way that we were internally passing arguments was causing a potential leak. By copying the arguments into an array we can avoid this - (Nathan Woltman) #4361 * repl: - Previously if you were using the repl in strict mode the column number would be wrong in a stack trace. This is no longer an issue. - (Prince J Wesley) #5416 PR-URL: #5961

Notable Changes * https: - Under certain conditions ssl sockets may have been causing a memory leak when keepalive is enabled. This is no longer the case. - (Alexander Penev) #5713 * lib: - The way that we were internally passing arguments was causing a potential leak. By copying the arguments into an array we can avoid this - (Nathan Woltman) #4361 * npm: - Upgrade to v2.15.1. (Forrest L Norvell) * repl: - Previously if you were using the repl in strict mode the column number would be wrong in a stack trace. This is no longer an issue. - (Prince J Wesley) #5416 PR-URL: #5961

Notable Changes * https: - Under certain conditions ssl sockets may have been causing a memory leak when keepalive is enabled. This is no longer the case. - (Alexander Penev) #5713 * lib: - The way that we were internally passing arguments was causing a potential leak. By copying the arguments into an array we can avoid this - (Nathan Woltman) #4361 * npm: - Upgrade to v2.15.1. Fixes a security flaw in the use of authentication tokens in HTTP requests that would allow an attacker to set up a server that could collect tokens from users of the command-line interface. Authentication tokens have previously been sent with every request made by the CLI for logged-in users, regardless of the destination of the request. This update fixes this by only including those tokens for requests made against the registry or registries used for the current install. (Forrest L Norvell) * repl: - Previously if you were using the repl in strict mode the column number would be wrong in a stack trace. This is no longer an issue. - (Prince J Wesley) #5416 PR-URL: #5961

mscdex added the repl Issues and PRs related to the REPL subsystem. label Feb 24, 2016

Fishrock123 reviewed Feb 24, 2016
View reviewed changes

repl: wrong repl stack trace column number in strict mode

00ebc4e

On strict mode, "'use strict'; void 0; " is added as prefix in order to prevent "use strict" as the result value for let/const statements. It causes wrong column number in stack trace.

princejwesley force-pushed the repl-linenumber branch from 5bd3401 to 00ebc4e Compare February 25, 2016 01:15

silverwind closed this Feb 29, 2016

Fishrock123 mentioned this pull request Mar 1, 2016

Release proposal: v5.7.1 #5464

Merged

5 tasks

jasnell added the lts-watch-v4.x label Mar 2, 2016

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Mar 30, 2016

This was referenced Mar 30, 2016

v4.4.2 proposal #5961

Merged

V4.4.1 proposal #5835

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repl: wrong repl stack trace column number in strict mode #5416

repl: wrong repl stack trace column number in strict mode #5416

princejwesley commented Feb 24, 2016

Fishrock123 Feb 24, 2016

princejwesley Feb 25, 2016

Fishrock123 commented Feb 24, 2016

cjihrig commented Feb 24, 2016

silverwind commented Feb 26, 2016

princejwesley commented Feb 29, 2016

silverwind commented Feb 29, 2016

silverwind commented Feb 29, 2016

jasnell commented Mar 2, 2016

MylesBorins commented Mar 17, 2016

MylesBorins commented Mar 30, 2016

repl: wrong repl stack trace column number in strict mode #5416

repl: wrong repl stack trace column number in strict mode #5416

Conversation

princejwesley commented Feb 24, 2016

Pull Request check-list

Affected core subsystem(s)

Description of change

Problem

Code for REPL with strict mode

Output

Behavior

Output (after fix)

Fishrock123 Feb 24, 2016

Choose a reason for hiding this comment

princejwesley Feb 25, 2016

Choose a reason for hiding this comment

Fishrock123 commented Feb 24, 2016

cjihrig commented Feb 24, 2016

silverwind commented Feb 26, 2016

princejwesley commented Feb 29, 2016

silverwind commented Feb 29, 2016

silverwind commented Feb 29, 2016

jasnell commented Mar 2, 2016

MylesBorins commented Mar 17, 2016

MylesBorins commented Mar 30, 2016