v16.8.0 release proposal #39875
Merged
v16.8.0 release proposal #39875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would like to apply for the role of a triager in this project. My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator! I hereby declare that I have read and understood the Code of Conduct and will adhere to that. PR-URL: #39757 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #37630 Fixes: #37618 Refs: #37618 (comment) Co-authored-by: Michaël Zasso <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
PR-URL: #39770 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Code samples that use CJS-only syntax need to use the cjs markdown identifiers. PR-URL: #39792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
PR-URL: #39791 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Adds a Environment flag to allow embedders to set CREATE_NO_WINDOW property when spawning processes, which is useful for GUI programs that do not want to show console windows when running terminal commands. PR-URL: #39712 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #38906 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #38906 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #39745 Fixes: #39744 Reviewed-By: Guy Bedford <[email protected]>
PR-URL: #37863 Co-authored-by: Antoine du Hamel <[email protected]> Co-authored-by: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
PR-URL: #39797 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Co-authored-by: Jiawen Geng <[email protected]> PR-URL: #34847 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This overload accepts the current Environment* as an argument, unlike the other constructor, which accepts an Isolate*. This is useful because we can pass the current Environment* directly instead of recomputing it from the Isolate* inside the constructor. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #39768 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Call the new constructor overload from the original constructor to reduce code duplication. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #39768 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: #39801 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
This commit combines two require() calls and subsequent destructuring operations. PR-URL: #39806 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: #39832 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Expose toUSVString so it can be used by user libraries. PR-URL: #39814 Refs: nodejs/undici#986 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849 PR-URL: #39840 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
PR-URL: #39818 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #39695 Backport-PR-URL: #39834 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Adds a helper util used to determine whether a stream has been disturbed (read or cancelled). Refs: #39627 PR-URL: #39628 Backport-PR-URL: #39819 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #39519 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Backport-PR-URL: #39820
PR-URL: #39813 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
- update intructions on adding cc for email to nodejs-sec mailing list as UI does not allow it to be done directly. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #39674 Reviewed-By: Colin Ihrig <[email protected]>
Original commit message:
[date] Fix Date#getMinutes() test failures
After building V8 using Clang (./out/x64.release/v8_build_config.json
says that "is_clang" is true), I could reproduce the referenced bug
report locally. Replacing the getMinutes() calls with getUTCMinutes()
calls fixed the test failure.
Signed-off-by: Darshan Sen <[email protected]>
Bug: v8:11200
Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Toon Verwaest <[email protected]>
Cr-Commit-Position: refs/heads/main@{#76367}
Refs: v8/v8@00bb1a7
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #39829
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #39833 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #35831 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This commit adds a note about only creating a CVE for Node.js vulnerabilities. The motivation for this is a recent HackerOne report where I created a CVE for a c-ares issue. This CVE should have been created by the c-ares project, and it was later, but we never updated our HackerOne report to use their CVE number. Hopefully this extra note in the release doc will help us check for this situaion and avoid this in the future. PR-URL: #39845 Refs: https://hackerone.com/reports/1178337 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: #39855 (comment) PR-URL: #39858 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
It would be great to have #39134 pulled in to supplement web streams support 🙄 |
|
@bricss yeah I agree, but nobody has done a backport of that PR for now. |
|
Okay, I see, it wasn't marked as backport |
We only mark as backport if there was a manual backport (with a pull request). |
BethGriggs
approved these changes
Aug 25, 2021
|
Any chance we could get #39608 as well? |
No, I don't have the time to update this proposal |
|
Any idea if/when #39594 will be included? |
@jasnell according to the changelog, it was included in v16.7.0: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V16.md#16.7.0 |
|
Ah!! Missed that entirely. Sigh. |
|
Release build: https://ci-release.nodejs.org/job/iojs+release/7129/ |
targos
added a commit
that referenced
this pull request
Aug 25, 2021
Notable changes: doc: * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906 stream: * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519 * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628 util: * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814 PR-URL: #39875
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Aug 25, 2021
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Aug 25, 2021
wwwzbwcom
pushed a commit
to wwwzbwcom/node
that referenced
this pull request
Aug 26, 2021
Notable changes: doc: * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) nodejs#38906 stream: * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) nodejs#39519 * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) nodejs#39628 util: * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) nodejs#39814 PR-URL: nodejs#39875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-08-25, Version 16.8.0 (Current), @targos
Notable Changes
2e90b10f35] - doc: deprecate type coercion fordns.lookupoptions (Antoine du Hamel) #38906a6d50a18a0] - (SEMVER-MINOR) stream: addstream.Duplex.fromutility (Robert Nagy) #39519af7047a815] - (SEMVER-MINOR) stream: addisDisturbedhelper (Robert Nagy) #3962866400374de] - (SEMVER-MINOR) util: exposetoUSVString(Robert Nagy) #39814Commits
90bf247a55] - build: fix update authors commit (Mestery) #39858c968372e37] - build: add authors.yml (Tierney Cyren) #358313f284cf65c] - build: add option to hide console window (Cheng Zhao) #39712a01e3ab41d] - deps: V8: cherry-pick 00bb1a77c03e (Darshan Sen) #39829cce95c4c5b] - deps: upgrade npm to 7.21.0 (Myles Borins) #39813254810a22e] - doc: add duplicate CVE check in sec. release doc (Daniel Bevenius) #398458c50d16712] - doc: improve description of the triagers team (Michaël Zasso) #39833c02165d992] - doc: update instructions for cc (Michael Dawson) #39674208305fd8f] - doc: move util.toUSVString() outside of deprecated group (Luigi Pinca) #398402e90b10f35] - doc: deprecate type coercion fordns.lookupoptions (Antoine du Hamel) #389068460a3216c] - doc: deprecate using non-boolean values in theverbatimoption (Antoine du Hamel) #389063041d57201] - doc: fix malformed changelog entries (Rich Trott) #397912b02f747c3] - doc: fix lint errors in packages.md (Rich Trott) #39792a387600d8f] - doc: add example of self-reference in scoped packages (Jesús Leganés-Combarro 'piranna) #376307a25bf3a6d] - doc: add himadriganguly as a triager (Himadri Ganguly) #39757d1900f43ce] - fs: combine require() and destructure (Colin Ihrig) #39806158d4464d2] - meta: add gyp as owner of gyp files and tools/gyp (Mary Marchini) #348478fa38500f2] - policy: canonicalize before resolving specifiers (Bradley Farias) #37863a7a217be13] - repl: fix tla function hoisting (Don Jayamanne) #397453a8399ee61] - src: return Maybe<bool> from InitializeContextRuntime() (Darshan Sen) #39695a704c9dfce] - (SEMVER-MINOR) src: call overload ctor from the original ctor (Darshan Sen) #397680918ea0683] - (SEMVER-MINOR) src: add a constructor overload for CallbackScope (Darshan Sen) #39768a6d50a18a0] - (SEMVER-MINOR) stream: duplexify (Robert Nagy) #39519af7047a815] - (SEMVER-MINOR) stream: add isDisturbed helper (Robert Nagy) #39628f98311a7c8] - tools: update workflow to open a pull request (Rich Trott) #39825d33f897509] - tools: use find-inactive-collaborators to modify README.md (Rich Trott) #39825d82ee96861] - tools: update gyp-next to v0.9.5 (Jiawen Geng) #3981879079ea01b] - tools: fix markdown linting (Rich Trott) #3983201093b07cc] - tools: update markdown linter dependencies and move to ESM (Antoine du Hamel) #398019dc0c91392] - tools: update rollup to latest version in markdown linter (Rich Trott) #39797c34e2534ab] - tools: update markdown lint dependencies (Rich Trott) #3977066400374de] - (SEMVER-MINOR) util: expose toUSVString (Robert Nagy) #39814