Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] stream: duplexify #39820

Closed
wants to merge 3 commits into from
Closed

[v16.x backport] stream: duplexify #39820

wants to merge 3 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 20, 2021

PR-URL: #39519
Reviewed-By: James M Snell [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Aug 20, 2021
ronag added a commit to nxtedition/node that referenced this pull request Aug 20, 2021
@ronag
stream: duplexify
2eb474e 
PR-URL: nodejs#39519
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Backport-PR-URL: nodejs#39820
@ronag ronag force-pushed the backport-39519-to-v16.x branch from defc2b4 to 2eb474e Compare August 20, 2021 13:46
@ronag ronag changed the title stream: duplexify [v16.x backport] stream: duplexify Aug 20, 2021
@ronag ronag requested a review from mcollina August 20, 2021 13:59
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Aug 20, 2021
mcollina
mcollina approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag
Copy link
Member Author

ronag commented Aug 20, 2021

@nodejs/streams

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@ronag ronag mentioned this pull request Aug 23, 2021
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39642/

@targos
Copy link
Member

targos commented Aug 23, 2021

Looks like it conflicts with af7047a

ronag added 3 commits August 23, 2021 14:24
@ronag
stream: duplexify
ea09812 
PR-URL: nodejs#39519
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Backport-PR-URL: nodejs#39820
@ronag
fixup
9506bc2
@ronag
fixup
6d303ea
@ronag ronag force-pushed the backport-39519-to-v16.x branch from e20a91c to 6d303ea Compare August 23, 2021 12:24
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@ronag
Copy link
Member Author

ronag commented Aug 23, 2021

resolved conflicts

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39643/

targos pushed a commit that referenced this pull request Aug 23, 2021
@ronag @targos
stream: duplexify
a6d50a1 
PR-URL: #39519
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Backport-PR-URL: #39820
@targos
Copy link
Member

targos commented Aug 23, 2021

Thanks. Landed in a6d50a1

@targos targos closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronag @nodejs-github-bot @targos @mcollina