module: fix ERR_REQUIRE_ESM error for null frames #39593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
errors
|
Requesting a fast track on this fix as well, please upvote this comment. //cc @nodejs/modules |
guybedford
referenced
this pull request
Jul 30, 2021
PR-URL: #39175 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
bmeck
approved these changes
Jul 30, 2021
guybedford
force-pushed
the
err-null-frame
branch
from
e52ea46 to
830c547
Compare
Trott
approved these changes
Jul 30, 2021
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 46e6c64...b0a6ade |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 31, 2021
PR-URL: #39593 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2021
PR-URL: #39593 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
This broke quite a few things like webpack and eslint, it would be good to have a 16.6.1 release with this fix included. |
|
I'm preparing a release for tomorrow. |
targos
pushed a commit
that referenced
this pull request
Aug 2, 2021
PR-URL: #39593 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where ERR_REQUIRE_ESM would throw a
endsWitherror for string when checking null error frames as reported in e2a6399#commitcomment-54198959.