Use node:16.5 for frontend instead of node:16

[zeripath]

Webpack does not appear to work on the latest node 16.6.0 and fails with an inscrutable
message.

I have been unable to work out what the problem is. This PR forcibly uses node 16.5 everywhere instead of node 16.

Close #16592

Signed-off-by: Andrew Thornton [email protected]

[zeripath]

Ah it might be something to do with webpack

[zeripath]

npx webpack
[webpack-cli] Failed to load '/home/andrew/src/go/gitea/webpack.config.js' config
[webpack-cli] TypeError: String.prototype.startsWith called on null or undefined
    at startsWith (<anonymous>)
    at node:internal/errors:811:19
    at Array.filter (<anonymous>)
    at node:internal/errors:809:16
    at prepareStackTrace (node:internal/errors:96:12)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:38)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (/home/andrew/src/go/gitea/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
make: *** [Makefile:710: public/js/index.js] Error 2

[codecov-commenter]

Codecov Report

Merging #16591 (a4f3c70) into main (72738f0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #16591      +/-   ##
==========================================
- Coverage   45.35%   45.35%   -0.01%     
==========================================
  Files         750      750              
  Lines       85096    85096              
==========================================
- Hits        38599    38594       -5     
- Misses      40252    40255       +3     
- Partials     6245     6247       +2     

Impacted Files	Coverage Δ
modules/notification/mail/mail.go	35.29% <0.00%> (-2.95%)	⬇️
models/unit.go	41.09% <0.00%> (-2.74%)	⬇️
modules/process/manager.go	72.83% <0.00%> (-2.47%)	⬇️
modules/notification/ui/ui.go	60.86% <0.00%> (-1.45%)	⬇️
models/notification.go	64.97% <0.00%> (-0.89%)	⬇️
models/repo_list.go	76.86% <0.00%> (-0.79%)	⬇️
models/error.go	39.07% <0.00%> (-0.47%)	⬇️
services/pull/pull.go	42.13% <0.00%> (+0.40%)	⬆️
services/pull/check.go	26.20% <0.00%> (+0.68%)	⬆️
services/pull/patch.go	55.93% <0.00%> (+1.69%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73e421...a4f3c70. Read the comment docs.

[zeripath]

OK there's a fix in node already regarding this: nodejs/node#39593

But node 16.7.0 has not been released as yet and is unlikely it appears to be released for a little while yet.

I'm not certain what is the best thing to do:

• This PR uses 16.5.0 which has a known sec issue - albeit one that doesn't affect us.
• Use node 14 instead of node 16 as node 14 is LTS #16592 switches us to use node:14 which is the LTS, which does not suffer this problem and should be more stable
• Or we leave things and wait for the node release.

In the meantime however we can't release, merge or build until this is sorted out.

Personally I vote for merging this and paying attention to node when it releases 16.7 but if another issue like this occurs we should seriously consider if we want to be running the latest version of node instead of the LTS. I think leaving our CI as broken is not a tolerable situation.

[6543]

agree - get this in and if something similar pop up use LTS :)