Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for debugger restart message issue #39273

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 5, 2021

Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: #39272

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 5, 2021
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2021
@nodejs-github-bot

This comment has been minimized.

@Trott
Copy link
Member Author

Trott commented Jul 5, 2021

Argh, the bug happens unreliably. It usually happens but not always.

@Trott
Copy link
Member Author

Trott commented Jul 5, 2021

Changed it to restart 32 64 times to try to make sure the error happens reliably. When this is moved out of known_issues, it can be reduced to 1 or 2.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Jul 7, 2021

@nodejs/testing

Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: nodejs#39272

PR-URL: nodejs#39273
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jul 8, 2021

Landed in b2fa795

@Trott Trott merged commit b2fa795 into nodejs:master Jul 8, 2021
@Trott Trott deleted the restart-twice branch July 8, 2021 03:57
targos pushed a commit that referenced this pull request Jul 11, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: #39272

PR-URL: #39273
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: #39272

PR-URL: #39273
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants