lib: refactored scheduling policy assignment #32663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
cluster
rickyes
reviewed
Apr 5, 2020
lib/internal/cluster/master.js
Outdated
| }; | ||
|
|
||
| // XXX(bnoordhuis) Fold cluster.schedulingPolicy into cluster.settings? | ||
| let { [process.env.NODE_CLUSTER_SCHED_POLICY]: schedulingPolicy } = schedulingPolicies; |
There was a problem hiding this comment.
lint-js rule check error is triggered :)
There was a problem hiding this comment.
Yes, my bad. Done 👍
yashLadha
force-pushed
the
chore/destructure_scheduling_policy
branch
from
c93cf14 to
2579e7f
Compare
|
@nodejs/cluster |
|
I'm really rather lukewarm when it comes to changes like this one. I might be biased because I wrote the current code but the new code is arguably less readable than the code it replaces. |
|
@bnoordhuis is it specific to destructuring or the naming. Just wanted to know the cause 😄 |
|
The destructuring. It's not that it's incredibly complex or difficult to follow, just harder to parse than the current code (IMO.) |
|
@bnoordhuis what should be the correct approach then according to you, because previously we are pulling the scheduling policy straight out from the hash which is not implying anything in general. 🤔 |
|
Well, if you want to make an improvement, how about this? let schedulingPolicy = process.env.NODE_CLUSTER_SCHED_POLICY;
if (schedulingPolicy === 'rr')
schedulingPolicy = SCHED_RR;
else if (schedulingPolicy === 'none')
schedulingPolicy = SCHED_NONE;
else if (process.platform === 'win32')
// Round-robin doesn't perform well on Windows due to the way IOCP is wired up.
schedulingPolicy = SCHED_NONE;
else
schedulingPolicy = SCHED_RR;That at least protects It's a marginal improvement but marginal improvements are improvements too. :-) |
yashLadha
force-pushed
the
chore/destructure_scheduling_policy
branch
from
2579e7f to
bc2ba78
Compare
In previous implementation it was clubbed into declaration of scheduling policies and fetching the schedulingPolicy. Now they are separate variables, so that in future if one want to add new scheduling policy. It is much simpler and not obsfucated.
yashLadha
force-pushed
the
chore/destructure_scheduling_policy
branch
from
bc2ba78 to
4985a2e
Compare
bnoordhuis
approved these changes
Apr 13, 2020
BridgeAR
approved these changes
May 3, 2020
addaleax
added
the
author ready
addaleax
pushed a commit
that referenced
this pull request
May 9, 2020
In previous implementation it was clubbed into declaration of scheduling policies and fetching the schedulingPolicy. Now they are separate variables, so that in future if one want to add new scheduling policy. It is much simpler and not obsfucated. PR-URL: #32663 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
Landed in 023bcde |
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
In previous implementation it was clubbed into declaration of scheduling policies and fetching the schedulingPolicy. Now they are separate variables, so that in future if one want to add new scheduling policy. It is much simpler and not obsfucated. PR-URL: #32663 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
In previous implementation it was clubbed into declaration of scheduling policies and fetching the schedulingPolicy. Now they are separate variables, so that in future if one want to add new scheduling policy. It is much simpler and not obsfucated. PR-URL: #32663 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation it was clubbed into declaration of scheduling
policies and fetching the schedulingPolicy. Now they are separate
variables, so that in future if one want to add new scheduling policy.
It is much simpler and not obsfucated.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes