lib: refactored scheduling policy assignment

In previous implementation it was clubbed into declaration of scheduling policies and fetching the schedulingPolicy. Now they are separate variables, so that in future if one want to add new scheduling policy. It is much simpler and not obsfucated. PR-URL: #32663 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · May 9, 2020 · 023bcde · 023bcde
1 parent fea01c1
commit 023bcde
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/lib/internal/cluster/master.js b/lib/internal/cluster/master.js
@@ -37,16 +37,17 @@ let debugPortOffset = 1;
 let initialized = false;
 
 // XXX(bnoordhuis) Fold cluster.schedulingPolicy into cluster.settings?
-let schedulingPolicy = {
-  'none': SCHED_NONE,
-  'rr': SCHED_RR
-}[process.env.NODE_CLUSTER_SCHED_POLICY];
-
-if (schedulingPolicy === undefined) {
-  // FIXME Round-robin doesn't perform well on Windows right now due to the
-  // way IOCP is wired up.
-  schedulingPolicy = (process.platform === 'win32') ? SCHED_NONE : SCHED_RR;
-}
+let schedulingPolicy = process.env.NODE_CLUSTER_SCHED_POLICY;
+if (schedulingPolicy === 'rr')
+  schedulingPolicy = SCHED_RR;
+else if (schedulingPolicy === 'none')
+  schedulingPolicy = SCHED_NONE;
+else if (process.platform === 'win32') {
+  // Round-robin doesn't perform well on
+  // Windows due to the way IOCP is wired up.
+  schedulingPolicy = SCHED_NONE;
+} else
+  schedulingPolicy = SCHED_RR;
 
 cluster.schedulingPolicy = schedulingPolicy;