Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add lookup to http.request() options #30353

Closed
wants to merge 1 commit into from
Closed

doc: add lookup to http.request() options #30353

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 10, 2019

Add documentation for the lookup option.

Fixes: #30171

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@lpinca
doc: add lookup to http.request() options
fbcdd60 
Add documentation for the `lookup` option.

Fixes: nodejs#30171
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Nov 10, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 10, 2019
@danbev
Copy link
Contributor

danbev commented Nov 13, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4040/

danbev pushed a commit that referenced this pull request Nov 13, 2019
@lpinca @danbev
doc: add lookup to http.request() options
5bd6f51 
Add documentation for the `lookup` option.

PR-URL: #30353
Fixes: #30171
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danbev
Copy link
Contributor

danbev commented Nov 13, 2019

Landed in 5bd6f51.

@danbev danbev closed this Nov 13, 2019
@lpinca lpinca deleted the gh-30171 branch November 13, 2019 08:19
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@lpinca @MylesBorins
doc: add lookup to http.request() options
c832565 
Add documentation for the `lookup` option.

PR-URL: #30353
Fixes: #30171
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@lpinca @targos
doc: add lookup to http.request() options
671e028 
Add documentation for the `lookup` option.

PR-URL: #30353
Fixes: #30171
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@lpinca @MylesBorins
doc: add lookup to http.request() options
d2c85f3 
Add documentation for the `lookup` option.

PR-URL: #30353
Fixes: #30171
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@antsmartian antsmartian antsmartian approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undocumented "lookup" option in http.request / http.get
10 participants
@lpinca @danbev @jasnell @Trott @antsmartian @benjamingr @cjihrig @devnexen @trivikr @nodejs-github-bot