Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undocumented "lookup" option in http.request / http.get #30171

Closed
davalapar opened this issue Oct 30, 2019 · 2 comments
Closed

undocumented "lookup" option in http.request / http.get #30171

davalapar opened this issue Oct 30, 2019 · 2 comments
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Comments

@davalapar
Copy link

Hi there, is the lookup option for http.request intentionally undocumented? Sindre's got uses it but I'd want to know if it's stable or not since it's not documented?
@bnoordhuis bnoordhuis added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Oct 31, 2019
@lpinca
Copy link
Member

lpinca commented Oct 31, 2019

Yes it's stable, it is forwarded to https://nodejs.org/api/net.html#net_socket_connect_options_connectlistener

@davalapar
Copy link
Author

awesome thank you!

i think it also defaults to https://nodejs.org/api/dns.html#dns_dns_lookup_hostname_options_callback, correct?

this is amazing 🎉 🎉

lpinca added a commit to lpinca/node that referenced this issue Nov 10, 2019
@lpinca
doc: add lookup to http.request() options
fbcdd60 
Add documentation for the `lookup` option.

Fixes: nodejs#30171
@lpinca lpinca mentioned this issue Nov 10, 2019
Closed
3 tasks
@danbev danbev closed this as completed in 5bd6f51 Nov 13, 2019
MylesBorins pushed a commit that referenced this issue Nov 17, 2019
@lpinca @MylesBorins
doc: add lookup to http.request() options
c832565 
Add documentation for the `lookup` option.

PR-URL: #30353
Fixes: #30171
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this issue Dec 1, 2019
@lpinca @targos
doc: add lookup to http.request() options
671e028 
Add documentation for the `lookup` option.

PR-URL: #30353
Fixes: #30171
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Dec 17, 2019
@lpinca @MylesBorins
doc: add lookup to http.request() options
d2c85f3 
Add documentation for the `lookup` option.

PR-URL: #30353
Fixes: #30171
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add lookup to http.request() options lpinca/node
3 participants
@bnoordhuis @lpinca @davalapar