v8.15.0 proposal #25177
Merged
v8.15.0 proposal #25177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
MylesBorins
force-pushed
the
v8.15.0-proposal
branch
from
a7336de to
06283cb
Compare
MylesBorins
force-pushed
the
v8.15.0-proposal
branch
from
06283cb to
d4331bf
Compare
MylesBorins
added a commit
that referenced
this pull request
Dec 21, 2018
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
PR-URL: #25177
richardlau
approved these changes
Dec 22, 2018
Refs: #25043 PR-URL: #25048 Reviewed-By: Myles Borins <[email protected]>
Fixes: #18254 PR-URL: #21393 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
See: #24958 PR-URL: #25037 Reviewed-By: Myles Borins <[email protected]>
This commit adds http_parser_set_max_header_size() to the http-parser for overriding the compile time maximum HTTP header size. Backport-PR-URL: #25171 PR-URL: #24811 Fixes: #24692 Refs: nodejs/http-parser#453 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Allow the maximum size of HTTP headers to be overridden from the command line. Backport-PR-URL: #25171 co-authored-by: Matteo Collina <[email protected]> PR-URL: #24811 Fixes: #24692 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins
force-pushed
the
v8.15.0-proposal
branch
from
d4331bf to
f0a96fc
Compare
MylesBorins
added a commit
that referenced
this pull request
Dec 22, 2018
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
PR-URL: #25177
cjihrig
approved these changes
Dec 22, 2018
This commit exposes the value of --max-http-header-size as a property of the http module. Backport-PR-URL: #25218 PR-URL: #24860 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
force-pushed
the
v8.15.0-proposal
branch
from
f0a96fc to
7a01ab2
Compare
|
CI: https://ci.nodejs.org/job/node-test-pull-request/19802/ ✅(single failure is known flake on AIX) |
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
* http:
- add maxHeaderSize property (cjihrig)
#24860
PR-URL: #25177
MylesBorins
force-pushed
the
v8.15.0-proposal
branch
from
7a01ab2 to
6d1c367
Compare
MylesBorins
added a commit
that referenced
this pull request
Dec 26, 2018
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
* http:
- add maxHeaderSize property (cjihrig)
#24860
PR-URL: #25177
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
The 8.14.0 security release introduced some unexpected breakages on
the 8.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable changes:
* cli:
- add --max-http-header-size flag (cjihrig)
nodejs#24811
* http:
- add maxHeaderSize property (cjihrig)
nodejs#24860
PR-URL: nodejs#25177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-12-26, Version 8.15.0 'Carbon' (LTS), @MylesBorins
The 8.14.0 security release introduced some unexpected breakages on the 8.x release line.
This is a special release to fix a regression in the HTTP binary upgrade response body and add
a missing CLI flag to adjust the max header size of the http parser.
Notable changes
Commits
693e362175] - (SEMVER-MINOR) cli: add --max-http-header-size flag (cjihrig) #248114fb5a1be2f] - (SEMVER-MINOR) deps: cherry-pick http_parser_set_max_header_size (cjihrig) #24811446f8b54e5] - (SEMVER-MINOR) http: add maxHeaderSize property (cjihrig) #24860215ecfe4de] - http: fix regression of binary upgrade response body (Matteo Collina) #25037e1fbc26c6a] - test: move test-benchmark-path to sequential (Rich Trott) #21393aef71c05a2] - test: mark test-http2-settings-flood as flaky on Windows (Rich Trott) #25048