[8.x] http: fix regression of binary upgrade response body #25037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
cc @MylesBorins @nodejs/lts |
mcollina
changed the title
2 tasks
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19521/ |
|
sequential/test-http2-settings-flood failed on same Windows variant both CI runs. Wouldn't think it's relevant, but maybe? Or maybe it's flaky on v8.x? |
|
Resume Build CI again: https://ci.nodejs.org/job/node-test-pull-request/19525/ ✔️ |
|
It's definitely not relevant. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2018
See: #24958 PR-URL: #25037 Reviewed-By: Myles Borins <[email protected]>
|
landed in a947b75 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2018
See: #24958 PR-URL: #25037 Reviewed-By: Myles Borins <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 22, 2018
See: #24958 PR-URL: #25037 Reviewed-By: Myles Borins <[email protected]>
This was referenced Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #24958
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes