-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests that call more
fail in Windows with Unicode shell codepage
#11469
Comments
more
fail in Windows with Unicode shell codepage
It seems the same with these two tests:
The same checks:
|
So I guess it should be documented that tests should be run in a non-Unicode codepage. |
Or maybe the test runner (or a concerned test / |
I can reproduce this on Windows 7 and 2008R2 but cannot on Windows Server 2012R2. So, this looks like an issue with I suspect |
I can't reproduce this on Windows 8.1 (6.3.9600). |
See also: #11470 |
@vsemozhetbyt do you want to submit a PR for this? |
@TimothyGu If @joaocgreis has no plans to do this, I can try. However, I am not good at *nix shell tools so I can overlook something. |
I've added this to my queue, but I'm not likely to get there soon. Feel free to go ahead, I can help review. |
@joaocgreis The PR, PTAL. |
PR-URL: #11953 Fixes: #11469 Reviewed-By: João Reis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
test\parallel\test-child-process-stdin.js
usesmore
command and does not expect any error messages in the stderr (seecommon.mustNotCall()
).However, some core Windows shell commands work wrong with Unicode shell codepage. See this answer.
To check
more
command:To check
test\parallel\test-child-process-stdin.js
pass:The text was updated successfully, but these errors were encountered: