4 Failing tests in master

[vsemozhetbyt]

• Version: 8.0.0-pre
• Platform: Windows 7 x64
• Subsystem: test

Today I've tried to build nodejs/node/master and v8/node/vee-eight-lkgr and I've got 4 similar test failures:

End of output (click me):

running 'python tools\test.py --mode=release  addons doctool known_issues message parallel sequential -J'
=== release test-child-process-spawn-shell ===
Path: parallel/test-child-process-spawn-shell
assert.js:85
  throw new assert.AssertionError({
  ^
AssertionError: '' === 'bar'
    at ChildProcess.command.on.common.mustCall (j:\temp\node-master\test\parallel\test-child-process-spawn-shell.js:48:10)
    at ChildProcess.<anonymous> (j:\temp\node-master\test\common.js:453:15)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:192:7)
    at maybeClose (internal/child_process.js:900:16)
    at Socket.<anonymous> (internal/child_process.js:342:11)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:189:7)
    at Pipe._handle.close [as _onclose] (net.js:501:12)
Command: j:\temp\node-master\Release\node.exe j:\temp\node-master\test\parallel\test-child-process-spawn-shell.js
=== release test-child-process-spawnsync-shell ===
Path: parallel/test-child-process-spawnsync-shell
assert.js:85
  throw new assert.AssertionError({
  ^
AssertionError: '' === 'bar'
    at Object.<anonymous> (j:\temp\node-master\test\parallel\test-child-process-spawnsync-shell.js:29:8)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:424:7)
    at startup (bootstrap_node.js:145:9)
    at bootstrap_node.js:539:3
Command: j:\temp\node-master\Release\node.exe j:\temp\node-master\test\parallel\test-child-process-spawnsync-shell.js
=== release test-child-process-stdin ===
Path: parallel/test-child-process-stdin
assert.js:85
  throw new assert.AssertionError({
  ^
AssertionError: function should not have been called
    at fail (j:\temp\node-master\test\common.js:503:10)
    at Socket.mustNotCall (j:\temp\node-master\test\common.js:509:5)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:189:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at Pipe.onread (net.js:551:20)
Command: j:\temp\node-master\Release\node.exe j:\temp\node-master\test\parallel\test-child-process-stdin.js
=== release test-child-process-stdio-inherit ===
Path: parallel/test-child-process-stdio-inherit
Not enough memory.

assert.js:85
  throw new assert.AssertionError({
  ^
AssertionError: '' === 'asdfasdf'
    at ChildProcess.<anonymous> (j:\temp\node-master\test\parallel\test-child-process-stdio-inherit.js:28:12)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:192:7)
    at maybeClose (internal/child_process.js:900:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
Command: j:\temp\node-master\Release\node.exe j:\temp\node-master\test\parallel\test-child-process-stdio-inherit.js
[06:17|% 100|+ 1384|-   4]: Done
running jslint

Sorry if this is a known issue.

[Fishrock123]

What Shell and Terminal are you running?

[vsemozhetbyt]

@Fishrock123 Simply cmd.exe.

[gibfahn]

cc/ @nodejs/platform-windows

[seishun]

Can't reproduce here. Can you try on another machine?

[gibfahn]

Could you post a commit hash as well?

[vsemozhetbyt]

@seishun Sorry, I can't :( But I can try in git bash on the same.

@gibfahn It puzzles me. How can I get it? Should I run git log in local master and copy the last commit hash?

[vsemozhetbyt]

I've launched the 4 test commands from the output in git bash and the result is the same.

I somehow can't rebuild in the git bash: any variations of the vcbuild test that occurred to me throw the error bash: vcbuild: command not found. How can I launch building in the git bash for Windows?

[seishun]

I don't think building in git bash is supported. And unless something changed in the last year or so, tests on Windows assume cmd too.

Perhaps you would be interested in investigating the test failures yourself?

[vsemozhetbyt]

@seishun I shall try.

I've just checked them with v7.5.0 and I've got the same errors.

Could anybody else also check these on Windows 7?

node test\parallel\test-child-process-spawn-shell.js
node test\parallel\test-child-process-spawnsync-shell.js
node test\parallel\test-child-process-stdin.js
node test\parallel\test-child-process-stdio-inherit.js

[joaocgreis]

Building in git bash should work fine with winpty vcbuild.bat test.

I see Not enough memory. in the last test, could that be related?

[vsemozhetbyt]

@joaocgreis It seems I've traced the problem with test\parallel\test-child-process-stdin.js and Not enough memory. I will post more exact issue soon.

[joaocgreis]

I can't reproduce these failures on my Windows 7 VM.

[vsemozhetbyt]

@joaocgreis @seishun One bug detected: #11469

[vsemozhetbyt]

Another one: #11470

[vsemozhetbyt]

And the last two: #11469 (comment)

I will close this issue in favor of those.