test: fix asyncworker test so it runs on 6.x #298
Conversation
|
@gabrielschulhof can you please review/approve. |
|
Maybe we should refine this to perform the async work irrespective of whether hooks are available or not, but to not create, nor check the result of the promise if the hooks are unavailable. |
|
@gabrielschulhof I think it now does what you suggested. It checks which version its running on and runs different tests on 6.x. |
There was a problem hiding this comment.
@mhdawson oh, you're right. I read the diff wrong. Its behaviour is unchanged if the async_hooks are present, and doing merely the async work is the addition.
|
Going to land this without waiting the usual 48 hours as it fixes a regression and we have 2 approvals. |
|
Also as an FYI, figured out how to have a run of the tests nightly on all of the LTS versions. Job is here: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/ The way it reports failures is not great as it's not clear which version the failure was on, but at least its a start and the info is available if you look at the console output for the top level job. |
PR-URL: #298 Fixes: #296 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
|
Landed as dd1191e |
PR-URL: nodejs/node-addon-api#298 Fixes: nodejs/node-addon-api#296 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
PR-URL: nodejs/node-addon-api#298 Fixes: nodejs/node-addon-api#296 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
PR-URL: nodejs/node-addon-api#298 Fixes: nodejs/node-addon-api#296 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
PR-URL: nodejs/node-addon-api#298 Fixes: nodejs/node-addon-api#296 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
Fixes: #296