Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-addon-api test broken on 6.x #296

Closed
mhdawson opened this issue Jul 11, 2018 · 2 comments
Closed

node-addon-api test broken on 6.x #296

mhdawson opened this issue Jul 11, 2018 · 2 comments

Comments

@mhdawson
Copy link
Member

Seems the tests were broken on 6.x when I landed 4b8918b.

It is just the test, not an ABI breakage:

Starting test suite

Running test 'arraybuffer'
Running test 'asyncworker'
module.js:478
    throw err;
    ^

Error: Cannot find module 'async_hooks'
    at Function.Module._resolveFilename (module.js:476:15)
    at Function.Module._load (module.js:424:25)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/mhdawson/newpull/node-addon-api/test/asyncworker.js:4:21)
    at Module._compile (module.js:577:32)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
npm ERR! Test failed.  See above for more details.

@mhdawson
Copy link
Member Author

Working on fix.

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Jul 11, 2018 via email

gabrielschulhof pushed a commit to gabrielschulhof/node-addon-api that referenced this issue Jul 11, 2018
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants