-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-addon-api test broken on 6.x #296
Comments
Working on fix. |
Don't worry. I have a fix, just haven't had a chance to submit it yet.
…On Wed, Jul 11, 2018 at 4:14 PM, Michael Dawson ***@***.***> wrote:
Working on fix.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#296 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA7k0cAm84ZAB4Njt5OYlOp_-OQB3hPsks5uFlyngaJpZM4VLxpu>
.
|
gabrielschulhof
pushed a commit
to gabrielschulhof/node-addon-api
that referenced
this issue
Jul 11, 2018
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this issue
Aug 24, 2022
PR-URL: nodejs/node-addon-api#298 Fixes: nodejs/node-addon-api#296 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this issue
Aug 26, 2022
PR-URL: nodejs/node-addon-api#298 Fixes: nodejs/node-addon-api#296 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this issue
Sep 19, 2022
PR-URL: nodejs/node-addon-api#298 Fixes: nodejs/node-addon-api#296 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this issue
Aug 11, 2023
PR-URL: nodejs/node-addon-api#298 Fixes: nodejs/node-addon-api#296 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems the tests were broken on 6.x when I landed 4b8918b.
It is just the test, not an ABI breakage:
The text was updated successfully, but these errors were encountered: