doc: update examples for context sensitivity #1013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
reviewed
Jun 22, 2021
| constructor.SuppressDestruct(); | ||
| Napi::FunctionReference *constructor = new Napi::FunctionReference(); | ||
| *constructor = Napi::Persistent(func); | ||
| env.SetInstanceData(constructor); |
There was a problem hiding this comment.
A finalizer is required for this FunctionReference pointer right?
There was a problem hiding this comment.
Hi @legendecas ,
Good question... I was under the impression that the instance data would be deleted, so there would be no need for a Finalizer.
- In the case of multiple calls to
Example::Init, the previous instance data would be overwritten via most recent call toenv.SetInstanceData. https://github.com/nodejs/node/blob/d615aeb7583b15bb5a8d1ec666ea29b8c7377455/src/js_native_api_v8.cc#L3201-L3205 does this delete the data? - The final data would be
deleted on environment cleanup.
Is my understanding correct?
There was a problem hiding this comment.
Eh, IIUC, it's node-addon-api's default finalizer deleted the data pointer: https://github.com/nodejs/node-addon-api/blob/main/napi.h#L208. Not quite intuitive tho... So no finalizer is required here.
There was a problem hiding this comment.
The Delete you point out only deleting the RefBase structure allocated in Node.js core, which would invoke the finalizer provided by node-addon-api. (Update: no, the lines don't invoke finalizers as they are replacing existing instance data)
legendecas
approved these changes
Jun 22, 2021
mhdawson
pushed a commit
that referenced
this pull request
Jul 9, 2021
Fixes: #1011 PR-URL: #1013 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
|
Landed as 627dbf3 |
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Sep 23, 2021
Fixes: nodejs#1011 PR-URL: nodejs#1013 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Oct 15, 2021
Fixes: nodejs#1011 PR-URL: nodejs#1013 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Fixes: nodejs/node-addon-api#1011 PR-URL: nodejs/node-addon-api#1013 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Fixes: nodejs/node-addon-api#1011 PR-URL: nodejs/node-addon-api#1013 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Fixes: nodejs/node-addon-api#1011 PR-URL: nodejs/node-addon-api#1013 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Fixes: nodejs/node-addon-api#1011 PR-URL: nodejs/node-addon-api#1013 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1011