doc: update examples for context sensitivity

Fixes: nodejs/node-addon-api#1011 PR-URL: nodejs/node-addon-api#1013 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
johnfrench3 · Jul 9, 2021 · e84faa5 · e84faa5
1 parent 22c63db
commit e84faa5
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/doc/class_property_descriptor.md b/doc/class_property_descriptor.md
@@ -17,7 +17,6 @@ class Example : public Napi::ObjectWrap<Example> {
     Example(const Napi::CallbackInfo &info);
 
   private:
-    static Napi::FunctionReference constructor;
     double _value;
     Napi::Value GetValue(const Napi::CallbackInfo &info);
     void SetValue(const Napi::CallbackInfo &info, const Napi::Value &value);
@@ -31,8 +30,9 @@ Napi::Object Example::Init(Napi::Env env, Napi::Object exports) {
         InstanceAccessor<&Example::GetValue>("readOnlyProp")
     });
 
-    constructor = Napi::Persistent(func);
-    constructor.SuppressDestruct();
+    Napi::FunctionReference *constructor = new Napi::FunctionReference();
+    *constructor = Napi::Persistent(func);
+    env.SetInstanceData(constructor);
     exports.Set("Example", func);
 
     return exports;
@@ -45,8 +45,6 @@ Example::Example(const Napi::CallbackInfo &info) : Napi::ObjectWrap<Example>(inf
     this->_value = value.DoubleValue();
 }
 
-Napi::FunctionReference Example::constructor;
-
 Napi::Value Example::GetValue(const Napi::CallbackInfo &info) {
     Napi::Env env = info.Env();
     return Napi::Number::New(env, this->_value);