Warning on NODE_API_MODULE macro #888
Comments
gabrielschulhof
pushed a commit
to gabrielschulhof/node-addon-api
that referenced
this issue
Feb 1, 2021
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily. It is sufficient for it to be a local symbol because it is passed around as a function pointer. Furthermore, making it `static` fixes a warning. Fixes: nodejs#888
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this issue
Aug 24, 2022
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily. It is sufficient for it to be a local symbol because it is passed around as a function pointer. Furthermore, making it `static` fixes a warning. Fixes: nodejs/node-addon-api#888 PR-URL: nodejs/node-addon-api#896 Reviewed-By: Nicola Del Gobbo <[email protected]>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this issue
Aug 26, 2022
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily. It is sufficient for it to be a local symbol because it is passed around as a function pointer. Furthermore, making it `static` fixes a warning. Fixes: nodejs/node-addon-api#888 PR-URL: nodejs/node-addon-api#896 Reviewed-By: Nicola Del Gobbo <[email protected]>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this issue
Sep 19, 2022
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily. It is sufficient for it to be a local symbol because it is passed around as a function pointer. Furthermore, making it `static` fixes a warning. Fixes: nodejs/node-addon-api#888 PR-URL: nodejs/node-addon-api#896 Reviewed-By: Nicola Del Gobbo <[email protected]>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this issue
Aug 11, 2023
The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily. It is sufficient for it to be a local symbol because it is passed around as a function pointer. Furthermore, making it `static` fixes a warning. Fixes: nodejs/node-addon-api#888 PR-URL: nodejs/node-addon-api#896 Reviewed-By: Nicola Del Gobbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The NODE_API_MODULE macro produces the missing-declarations warning:
... warning: no previous declaration for 'napi_value__* __napi_Init(napi_env, napi_value)' [-Wmissing-declarations]
napi_value _napi ## regfunc(napi_env env,
^
...: note: in expansion of macro 'NODE_API_MODULE'
NODE_API_MODULE(dnp3, Init);
Why __napi_XXX function in the macro is not static to suppress this warning?
The text was updated successfully, but these errors were encountered: