src: remove unnecessary symbol exposure

The symbol generated by `NODE_API_MODULE()` is exposed unnecessarily. It is sufficient for it to be a local symbol because it is passed around as a function pointer. Furthermore, making it `static` fixes a warning. Fixes: nodejs/node-addon-api#888 PR-URL: nodejs/node-addon-api#896 Reviewed-By: Nicola Del Gobbo <[email protected]>
johnfrench3 · Feb 8, 2021 · c5e48e0 · c5e48e0
1 parent 41a1d56
commit c5e48e0
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/napi-inl.h b/napi-inl.h
@@ -344,12 +344,11 @@ struct AccessorCallbackData {
 ////////////////////////////////////////////////////////////////////////////////
 
 // Register an add-on based on an initializer function.
-#define NODE_API_MODULE(modname, regfunc)                 \
-  napi_value __napi_ ## regfunc(napi_env env,             \
-                                napi_value exports) {     \
-    return Napi::RegisterModule(env, exports, regfunc);   \
-  }                                                       \
-  NAPI_MODULE(modname, __napi_ ## regfunc)
+#define NODE_API_MODULE(modname, regfunc)                                      \
+  static napi_value __napi_##regfunc(napi_env env, napi_value exports) {       \
+    return Napi::RegisterModule(env, exports, regfunc);                        \
+  }                                                                            \
+  NAPI_MODULE(modname, __napi_##regfunc)
 
 // Register an add-on based on a subclass of `Addon<T>` with a custom Node.js
 // module name.