-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the ccache/git latest version fetch #1312
Simplify the ccache/git latest version fetch #1312
Conversation
If we think it's ok to merge this I'll squash the commits |
Need to make sure I'd run BTW @LucaLanziani Do you have experience with setting up an Ansible Tower (or AWX or Semaphore). It might be useful for running playbooks for maintenance and upgrades. ATM we use sometimes use Jenkins jobs for that. |
Use an ansible filter to fetch the latest version Still to verify if the `grep -Eo` works as expected on OSX
With the current version of the regex we are matching even non semver version (eg. versions with 4 digits) This solution seems to work with any number of digits on the version. A possible alternative (we might prefer) is that to change the regex only to match versions with 2/3 digits and then we can go back using the python `StrictVersion` function.
Yeah, this is exactly my fear. Unfortunately @refack I have no experience with Ansible Tower or alternatives, never had to use it, I use jenkins too in my projects. Btw I saw that in the previous implementation the code was just matching semver version (2 or 3 digits) ignoring the versions with 4 digits. |
Ansible offers the regex_findall filter that works like the grep -Eo with the plus of being OS independent.
@refack the last commit should solve the |
@maclover7 sure, |
Landed in bb7ac13 |
Use an ansible filter to fetch the latest version
Still to verify if the
grep -Eo
works as expected on OSX